RE: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2021-01-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 23 December 2020 16:46 > To: Julien Grall ; Paul Durrant > Cc: hongy...@amazon.co.uk; Julien Grall ; > xen-devel@lists.xenproject.org > Subject: Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root > p

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
Hi Jan, On 23/12/2020 17:02, Jan Beulich wrote: On 23.12.2020 17:54, Julien Grall wrote: On 23/12/2020 16:46, Jan Beulich wrote: On 23.12.2020 17:29, Julien Grall wrote: On 23/12/2020 16:24, Jan Beulich wrote: On 23.12.2020 17:16, Julien Grall wrote: On 23/12/2020 16:11, Jan Beulich wrote

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 23.12.2020 17:54, Julien Grall wrote: > > > On 23/12/2020 16:46, Jan Beulich wrote: >> On 23.12.2020 17:29, Julien Grall wrote: >>> On 23/12/2020 16:24, Jan Beulich wrote: On 23.12.2020 17:16, Julien Grall wrote: > On 23/12/2020 16:11, Jan Beulich wrote: >> On 23.12.2020 16:16, Ju

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
On 23/12/2020 16:46, Jan Beulich wrote: On 23.12.2020 17:29, Julien Grall wrote: On 23/12/2020 16:24, Jan Beulich wrote: On 23.12.2020 17:16, Julien Grall wrote: On 23/12/2020 16:11, Jan Beulich wrote: On 23.12.2020 16:16, Julien Grall wrote: On 23/12/2020 15:00, Jan Beulich wrote: On 23

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 23.12.2020 17:29, Julien Grall wrote: > On 23/12/2020 16:24, Jan Beulich wrote: >> On 23.12.2020 17:16, Julien Grall wrote: >>> On 23/12/2020 16:11, Jan Beulich wrote: On 23.12.2020 16:16, Julien Grall wrote: > On 23/12/2020 15:00, Jan Beulich wrote: >> On 23.12.2020 15:56, Julien G

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
On 23/12/2020 16:24, Jan Beulich wrote: On 23.12.2020 17:16, Julien Grall wrote: On 23/12/2020 16:11, Jan Beulich wrote: On 23.12.2020 16:16, Julien Grall wrote: On 23/12/2020 15:00, Jan Beulich wrote: On 23.12.2020 15:56, Julien Grall wrote: On 23/12/2020 14:12, Jan Beulich wrote: On 22

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 23.12.2020 17:16, Julien Grall wrote: > On 23/12/2020 16:11, Jan Beulich wrote: >> On 23.12.2020 16:16, Julien Grall wrote: >>> On 23/12/2020 15:00, Jan Beulich wrote: On 23.12.2020 15:56, Julien Grall wrote: > On 23/12/2020 14:12, Jan Beulich wrote: >> On 22.12.2020 16:43, Julien G

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
Hi, On 23/12/2020 16:11, Jan Beulich wrote: On 23.12.2020 16:16, Julien Grall wrote: On 23/12/2020 15:00, Jan Beulich wrote: On 23.12.2020 15:56, Julien Grall wrote: On 23/12/2020 14:12, Jan Beulich wrote: On 22.12.2020 16:43, Julien Grall wrote: This is an RFC because it would break AMD IO

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 23.12.2020 16:16, Julien Grall wrote: > On 23/12/2020 15:00, Jan Beulich wrote: >> On 23.12.2020 15:56, Julien Grall wrote: >>> On 23/12/2020 14:12, Jan Beulich wrote: On 22.12.2020 16:43, Julien Grall wrote: > This is an RFC because it would break AMD IOMMU driver. One option would >>>

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
Hi Jan, On 23/12/2020 15:00, Jan Beulich wrote: On 23.12.2020 15:56, Julien Grall wrote: On 23/12/2020 14:12, Jan Beulich wrote: On 22.12.2020 16:43, Julien Grall wrote: This is an RFC because it would break AMD IOMMU driver. One option would be to move the call to the teardown callback earli

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 23.12.2020 15:56, Julien Grall wrote: > On 23/12/2020 14:12, Jan Beulich wrote: >> On 22.12.2020 16:43, Julien Grall wrote: >>> This is an RFC because it would break AMD IOMMU driver. One option would >>> be to move the call to the teardown callback earlier on. Any opinions? >> >> We already hav

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Julien Grall
Hi Jan, On 23/12/2020 14:12, Jan Beulich wrote: On 22.12.2020 16:43, Julien Grall wrote: From: Julien Grall The new per-domain IOMMU page-table allocator will now free the page-tables when domain's resources are relinquished. However, the root page-table (i.e. hd->arch.pg_maddr) will not be c

Re: [PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-23 Thread Jan Beulich
On 22.12.2020 16:43, Julien Grall wrote: > From: Julien Grall > > The new per-domain IOMMU page-table allocator will now free the > page-tables when domain's resources are relinquished. However, the root > page-table (i.e. hd->arch.pg_maddr) will not be cleared. > > Xen may access the IOMMU page

[PATCH for-4.15 3/4] [RFC] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2020-12-22 Thread Julien Grall
From: Julien Grall The new per-domain IOMMU page-table allocator will now free the page-tables when domain's resources are relinquished. However, the root page-table (i.e. hd->arch.pg_maddr) will not be cleared. Xen may access the IOMMU page-tables afterwards at least in the case of PV domain: