On 19.11.2021 18:09, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH for-4.16 v3] efi: fix alignment of function
> parameters in compat mode"):
>> Some hardtabs appear to have slipped in.
>
> Thanks. Fixed.
>
>> Jan gave a conditional R-by which
Andrew Cooper writes ("Re: [PATCH for-4.16 v3] efi: fix alignment of function
parameters in compat mode"):
> Some hardtabs appear to have slipped in.
Thanks. Fixed.
> Jan gave a conditional R-by which permitted a change along these lines,
> but he's left the office no
On 19/11/2021 15:24, Ian Jackson wrote:
> diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
> index 375b94229e..089bb0eb1b 100644
> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -638,16 +641,36 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
>
>
From: Roger Pau Monne
Currently the max_store_size, remain_store_size and max_size in
compat_pf_efi_runtime_call are 4 byte aligned, which makes clang
13.0.0 complain with:
In file included from compat.c:30:
./runtime.c:646:13: error: passing 4-byte aligned argument to 8-byte aligned
parameter
