Re: [PATCH for-4.20 3/4] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-08-07 Thread Alejandro Vallejo
Hi. Sorry, I've been busy and couldn't get back to this sooner. On Fri Jul 19, 2024 at 10:14 AM BST, Jan Beulich wrote: > On 18.07.2024 18:54, Alejandro Vallejo wrote: > > On Thu Jul 18, 2024 at 12:49 PM BST, Jan Beulich wrote: > >> On 09.07.2024 17:52, Alejandro Vallejo wrote: > >>> --- a/xen/arc

Re: [PATCH for-4.20 3/4] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-07-19 Thread Jan Beulich
On 18.07.2024 18:54, Alejandro Vallejo wrote: > On Thu Jul 18, 2024 at 12:49 PM BST, Jan Beulich wrote: >> On 09.07.2024 17:52, Alejandro Vallejo wrote: >>> --- a/xen/arch/x86/include/asm/domain.h >>> +++ b/xen/arch/x86/include/asm/domain.h >>> @@ -591,12 +591,7 @@ struct pv_vcpu >>> >>> struct

Re: [PATCH for-4.20 3/4] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-07-18 Thread Alejandro Vallejo
On Thu Jul 18, 2024 at 12:49 PM BST, Jan Beulich wrote: > On 09.07.2024 17:52, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/domctl.c > > +++ b/xen/arch/x86/domctl.c > > @@ -1343,7 +1343,8 @@ void arch_get_info_guest(struct vcpu *v, > > vcpu_guest_context_u c) > > #define c(fld) (c.nat->fld) >

Re: [PATCH for-4.20 3/4] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-07-18 Thread Jan Beulich
On 09.07.2024 17:52, Alejandro Vallejo wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -1343,7 +1343,8 @@ void arch_get_info_guest(struct vcpu *v, > vcpu_guest_context_u c) > #define c(fld) (c.nat->fld) > #endif > > -memcpy(&c.nat->fpu_ctxt, v->arch.fpu_ctxt, sizeof

[PATCH for-4.20 3/4] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-07-09 Thread Alejandro Vallejo
fpu_ctxt is either a pointer to the legacy x87/SSE save area (used by FXSAVE) or a pointer aliased with xsave_area that points to its fpu_sse subfield. Such subfield is at the base and is identical in size and layout to the legacy buffer. This patch merges the 2 pointers in the arch_vcpu into a si