On Thu, 28 Aug 2024, Lira, Victor M wrote:
> Hello Michal,
>
> Unfortunately only removing "set +e" did not fix the issue as the test still
> will always pass.
> See here (line 90):
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/7700210695
>
> I think we will need to use the fifo
Hello Michal,
Unfortunately only removing "set +e" did not fix the issue as the test
still will always pass.
See here (line 90):
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/7700210695
I think we will need to use the fifo or the Bash "pipefail" function.
You may want to use "
Hi Victor,
On 29/08/2024 06:09, victorm.l...@amd.com wrote:
>
>
> From: Victor Lira
>
> Fix flaw in qemu-*.sh tests that producess a false success. The following
> lines produces success despite the "expect" script producing nonzero exit
> status.
>
> set +e
> ...
> ./automation/scrip
While developing a patch to update xilinx tests to use the "expect"
utility I found that with the current use of "expect" in the *qemu-*
*scripts,
it is possible for the test to produce a *false success *if the expect
script returns nonzero due to the following lines
set +e
...
./automa
From: Victor Lira
Fix flaw in qemu-*.sh tests that producess a false success. The following
lines produces success despite the "expect" script producing nonzero exit
status.
set +e
...
./automation/scripts/qemu-key.exp | sed 's/\r\+$//'
(end of file)
The "set +e" is sometimes needed
