In case of truncation no trailing zero will be added to the target
string. Reduce the amount of bytes to copy by one to make sure a
trailing zero always exists.
In file included from /usr/include/string.h:495,
from libxl_internal.h:38,
from libxl_utils.c:20:
In fu
Am Mon, 8 Jun 2020 09:28:54 +0200
schrieb Olaf Hering :
> off-by-one error in libxl__prepare_sockaddr_un
There is none, I had read the code backwards...
Olaf
pgpFP2LeUeAH4.pgp
Description: Digitale Signatur von OpenPGP
Olaf Hering writes ("Re: [PATCH v1] tools: fix usage of strncpy"):
> Am Mon, 8 Jun 2020 09:28:54 +0200
> schrieb Olaf Hering :
> > off-by-one error in libxl__prepare_sockaddr_un
>
> There is none, I had read the code backwards...
I have just had the same though
On Mon, Jun 8, 2020 at 7:03 AM Ian Jackson wrote:
>
> Olaf Hering writes ("Re: [PATCH v1] tools: fix usage of strncpy"):
> > Am Mon, 8 Jun 2020 09:28:54 +0200
> > schrieb Olaf Hering :
> > > off-by-one error in libxl__prepare_sockaddr_un
> >
>
Am Mon, 8 Jun 2020 08:43:50 -0400
schrieb Jason Andryuk :
> I added a length check in this patch:
gcc will not recognize such runtime checks and will (most likely) complain
about the strncpy usage anyway, just as it does now in
libxl__prepare_sockaddr_un. While the usage in libxl__prepare_socka
On Mon, Jun 8, 2020 at 10:11 AM Olaf Hering wrote:
>
> Am Mon, 8 Jun 2020 08:43:50 -0400
> schrieb Jason Andryuk :
>
> > I added a length check in this patch:
>
> gcc will not recognize such runtime checks and will (most likely) complain
> about the strncpy usage anyway, just as it does now in
>
Am Tue, 9 Jun 2020 08:33:12 -0400
schrieb Jason Andryuk :
> What version of gcc are you using? I was using 9.x and it didn't warn from
> what I can remember.
This is gcc10 from current Tumbleweed. For libxl strcpy will certainly work
because the length check is done prior the copying of data.
On Jun 8, 2020, at 10:12, Olaf Hering wrote:
>
> Am Mon, 8 Jun 2020 08:43:50 -0400
> schrieb Jason Andryuk :
>
>> I added a length check in this patch:
>
> gcc will not recognize such runtime checks and will (most likely) complain
> about the strncpy usage anyway, just as it does now in
> li
Am Tue, 9 Jun 2020 12:35:51 -0400
schrieb Rich Persaud :
> Is there any reason not to take a patch that builds libvchan with -Werror?
The per-subdirectory settings of -Werror should probably become a global
-Werror. Someone has to step up and explore that path.
Bonus points if -Werror could be d
