Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-11 Thread Jan Beulich
On 11.05.2023 15:59, Julien Grall wrote: > On 11/05/2023 14:49, Stewart Hildebrand wrote: >> On 5/8/23 10:51, Jan Beulich wrote: >>> On 08.05.2023 16:16, Stewart Hildebrand wrote: On 5/2/23 03:50, Jan Beulich wrote: > On 01.05.2023 22:03, Stewart Hildebrand wrote: >> --- a/xen/drivers/

Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-11 Thread Julien Grall
Hi, Can you make sure to CC the Arm/SMMU maintainers as I feel it is important for them to also review the generic changes. On 11/05/2023 14:49, Stewart Hildebrand wrote: On 5/8/23 10:51, Jan Beulich wrote: On 08.05.2023 16:16, Stewart Hildebrand wrote: On 5/2/23 03:50, Jan Beulich wrote:

Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-11 Thread Stewart Hildebrand
On 5/8/23 10:51, Jan Beulich wrote: > On 08.05.2023 16:16, Stewart Hildebrand wrote: >> On 5/2/23 03:50, Jan Beulich wrote: >>> On 01.05.2023 22:03, Stewart Hildebrand wrote: --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1305,7 +1305,7 @@ __initcall(setu

Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-08 Thread Jan Beulich
On 08.05.2023 16:16, Stewart Hildebrand wrote: > On 5/2/23 03:50, Jan Beulich wrote: >> On 01.05.2023 22:03, Stewart Hildebrand wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); >>> >>> static int iommu_

Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-08 Thread Stewart Hildebrand
On 5/2/23 03:50, Jan Beulich wrote: > On 01.05.2023 22:03, Stewart Hildebrand wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); >> >> static int iommu_add_device(struct pci_dev *pdev) >> { >> -const st

Re: [PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-02 Thread Jan Beulich
On 01.05.2023 22:03, Stewart Hildebrand wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -1305,7 +1305,7 @@ __initcall(setup_dump_pcidevs); > > static int iommu_add_device(struct pci_dev *pdev) > { > -const struct domain_iommu *hd; > +const struct

[PATCH v1 4/6] pci/arm: Use iommu_add_dt_pci_device() instead of arch hook

2023-05-01 Thread Stewart Hildebrand
From: Oleksandr Tyshchenko On Arm we need to parse DT PCI-IOMMU specifier and provide it to the driver (for describing the relationship between PCI devices and IOMMUs) before adding a device to it. Also clarify the check of the return value as iommu_add_pci_device can return >0 if a device doesn