[PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-11-30 Thread Edwin Török
Add a .clang-format configuration that tries to match CODING_STYLE where possible. I was not able to express the special casing of braces after 'do' though, this can only be controlled generally for all control statements. It is imperfect, but should be better than the existing bindings, which do

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Julien Grall
Hi Edwin, The title should have "OCaml" to clarify that .clang-format is not added at the root level. On 30/11/2022 17:32, Edwin Török wrote: Add a .clang-format configuration that tries to match CODING_STYLE where possible. I was not able to express the special casing of braces after 'do' t

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Edwin Torok
> On 1 Dec 2022, at 09:11, Julien Grall wrote: > > Hi Edwin, > > The title should have "OCaml" to clarify that .clang-format is not added at > the root level. > Sure, I'll update that when I resend. > On 30/11/2022 17:32, Edwin Török wrote: >> Add a .clang-format configuration that tries t

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Christian Lindig
> On 30 Nov 2022, at 17:32, Edwin Török wrote: > > Add a .clang-format configuration that tries to match CODING_STYLE where > possible > [..] > Does not yet reformat any code. > > No functional change. > > Signed-off-by: Edwin Török > --- > tools/ocaml/.clang-format | 9 + > 1 file c

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Julien Grall
(+ A few people) On 01/12/2022 09:21, Edwin Torok wrote: On 1 Dec 2022, at 09:11, Julien Grall wrote: Hi Edwin, The title should have "OCaml" to clarify that .clang-format is not added at the root level. Sure, I'll update that when I resend. On 30/11/2022 17:32, Edwin Török wrote: A

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Juergen Gross
On 01.12.22 10:31, Julien Grall wrote: (+ A few people) On 01/12/2022 09:21, Edwin Torok wrote: On 1 Dec 2022, at 09:11, Julien Grall wrote: Hi Edwin, The title should have "OCaml" to clarify that .clang-format is not added at the root level. Sure, I'll update that when I resend. O

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Julien Grall
On 01/12/2022 10:08, Juergen Gross wrote: On 01.12.22 10:31, Julien Grall wrote: (+ A few people) On 01/12/2022 09:21, Edwin Torok wrote: On 1 Dec 2022, at 09:11, Julien Grall wrote: Hi Edwin, The title should have "OCaml" to clarify that .clang-format is not added at the root level.

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Juergen Gross
On 01.12.22 11:12, Julien Grall wrote: On 01/12/2022 10:08, Juergen Gross wrote: On 01.12.22 10:31, Julien Grall wrote: (+ A few people) On 01/12/2022 09:21, Edwin Torok wrote: On 1 Dec 2022, at 09:11, Julien Grall wrote: Hi Edwin, The title should have "OCaml" to clarify that .clang-

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Julien Grall
On 01/12/2022 10:44, Juergen Gross wrote: On 01.12.22 11:12, Julien Grall wrote: We might want to add a comment to xs_wire.h like the one in ring.h in order to document the requirement of the type definition of uint32_t. The problem with this approach is you made more difficult for any us

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Jan Beulich
On 01.12.2022 11:47, Julien Grall wrote: > > > On 01/12/2022 10:44, Juergen Gross wrote: >> On 01.12.22 11:12, Julien Grall wrote: We might want to add a comment to xs_wire.h like the one in ring.h in order to document the requirement of the type definition of uint32_t. >>> >>> Th

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Julien Grall
On 01/12/2022 11:30, Jan Beulich wrote: On 01.12.2022 11:47, Julien Grall wrote: On 01/12/2022 10:44, Juergen Gross wrote: On 01.12.22 11:12, Julien Grall wrote: We might want to add a comment to xs_wire.h like the one in ring.h in order to document the requirement of the type definition

Re: [PATCH v1 5/5] CODING_STYLE: add .clang-format

2022-12-01 Thread Jan Beulich
On 01.12.2022 12:35, Julien Grall wrote: > On 01/12/2022 11:30, Jan Beulich wrote: >> On 01.12.2022 11:47, Julien Grall wrote: >>> On 01/12/2022 10:44, Juergen Gross wrote: On 01.12.22 11:12, Julien Grall wrote: >> We might want to add a comment to xs_wire.h like the one in ring.h in >