Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-09-05 Thread Dan Carpenter
On Mon, Aug 14, 2023 at 11:34:11AM +0530, Ratheesh Kannoth wrote: > Clamp to 32k instead of returning error. What is the motivation here? What is the real world impact for the users? > > Please find discussion at > https://lore.kernel.org/lkml/ > CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR18

Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-08-14 Thread Jesper Dangaard Brouer
On 14/08/2023 10.05, Ratheesh Kannoth wrote: From: Johannes Berg Subject: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. Please find discussion at https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_l I'm not the one who's going to apply this, but h

RE: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-08-14 Thread Ratheesh Kannoth
> From: Jesper Dangaard Brouer > Subject: Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. > I agree with Johannes, this commit message is too thin. ACK. > It makes sense to give a summary of the discussion, because it show us > (page_pool maintainers) what yo

RE: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-08-14 Thread Ratheesh Kannoth
> From: Johannes Berg > Subject: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. > > Please find discussion at > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_l > > > I'm not the one who's going to apply this, but honestly,

Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-08-14 Thread Johannes Berg
On Mon, 2023-08-14 at 11:34 +0530, Ratheesh Kannoth wrote: > Clamp to 32k instead of returning error. > > Please find discussion at > https://lore.kernel.org/lkml/ > CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR1801MB1911. > namprd18.prod.outlook.com/T/ > I'm not the one who's going to apply th

[PATCH v1 net] page_pool: Cap queue size to 32k.

2023-08-13 Thread Ratheesh Kannoth
Clamp to 32k instead of returning error. Please find discussion at https://lore.kernel.org/lkml/ CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR1801MB1911. namprd18.prod.outlook.com/T/ Fixes: ff7d6b27f894 ("page_pool: refurbish version of page_pool code") Signed-off-by: Ratheesh Kannoth --- Chan