Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-22 Thread Julien Grall
Hi, On 22/03/2022 16:16, Ayan Kumar Halder wrote: On 22/03/2022 13:22, Julien Grall wrote: Furthermore, I think try_fwd_ioserv() need to be adapted because the function will use the fields SAS and SRT. From the Arm Arm they are RES0, so while they are 0 today, we should not rely on this.

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-22 Thread Ayan Kumar Halder
Hi Julien, On 22/03/2022 13:22, Julien Grall wrote: Hi Ayan, On 22/03/2022 12:38, Ayan Kumar Halder wrote: On 22/03/2022 12:06, Ayan Kumar Halder wrote: On 18/03/2022 18:26, Julien Grall wrote: Hi Ayan, Hi Julien, On 17/03/2022 14:00, Ayan Kumar Halder wrote: diff --git

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-22 Thread Julien Grall
Hi Ayan, On 22/03/2022 12:38, Ayan Kumar Halder wrote: On 22/03/2022 12:06, Ayan Kumar Halder wrote: On 18/03/2022 18:26, Julien Grall wrote: Hi Ayan, Hi Julien, On 17/03/2022 14:00, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-22 Thread Ayan Kumar Halder
On 22/03/2022 12:06, Ayan Kumar Halder wrote: On 18/03/2022 18:26, Julien Grall wrote: Hi Ayan, Hi Julien, On 17/03/2022 14:00, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index ca259a79c2..79e64d9af8 100644 ---

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-22 Thread Ayan Kumar Halder
On 18/03/2022 18:26, Julien Grall wrote: Hi Ayan, Hi Julien, On 17/03/2022 14:00, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index ca259a79c2..79e64d9af8 100644 --- a/xen/arch/arm/include/asm/mmio.h +++

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-18 Thread Julien Grall
Hi Ayan, On 17/03/2022 14:00, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index ca259a79c2..79e64d9af8 100644 --- a/xen/arch/arm/include/asm/mmio.h +++ b/xen/arch/arm/include/asm/mmio.h @@ -35,6 +35,7 @@ enum instr_decode_state

Re: [PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-17 Thread Stefano Stabellini
On Thu, 17 Mar 2022, Ayan Kumar Halder wrote: > When the data abort is caused due to cache maintenance for an address, > there are three scenarios:- > > 1. Address belonging to a non emulated region - For this, Xen should > set the corresponding bit in the translation table entry to valid and >

[PATCH v11 3/3] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-17 Thread Ayan Kumar Halder
When the data abort is caused due to cache maintenance for an address, there are three scenarios:- 1. Address belonging to a non emulated region - For this, Xen should set the corresponding bit in the translation table entry to valid and return to the guest to retry the instruction. This can