Re: [PATCH v2] blkif: reconcile protocol specification with in-use implementations

2024-09-12 Thread Anthony PERARD
On Tue, Sep 10, 2024 at 04:01:50PM +0200, Jürgen Groß wrote: > On 10.09.24 15:59, Roger Pau Monné wrote: > > On Tue, Sep 10, 2024 at 03:46:00PM +0200, Jürgen Groß wrote: > > > On 10.09.24 13:46, Roger Pau Monne wrote: > > > > diff --git a/xen/include/public/io/blkif.h > > > > b/xen/include/public/

Re: [PATCH v2] blkif: reconcile protocol specification with in-use implementations

2024-09-10 Thread Jürgen Groß
On 10.09.24 15:59, Roger Pau Monné wrote: On Tue, Sep 10, 2024 at 03:46:00PM +0200, Jürgen Groß wrote: On 10.09.24 13:46, Roger Pau Monne wrote: Current blkif implementations (both backends and frontends) have all slight differences about how they handle the 'sector-size' xenstore node, and how

Re: [PATCH v2] blkif: reconcile protocol specification with in-use implementations

2024-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2024 at 03:46:00PM +0200, Jürgen Groß wrote: > On 10.09.24 13:46, Roger Pau Monne wrote: > > Current blkif implementations (both backends and frontends) have all slight > > differences about how they handle the 'sector-size' xenstore node, and how > > other fields are derived from t

Re: [PATCH v2] blkif: reconcile protocol specification with in-use implementations

2024-09-10 Thread Jürgen Groß
On 10.09.24 13:46, Roger Pau Monne wrote: Current blkif implementations (both backends and frontends) have all slight differences about how they handle the 'sector-size' xenstore node, and how other fields are derived from this value or hardcoded to be expressed in units of 512 bytes. To give so

[PATCH v2] blkif: reconcile protocol specification with in-use implementations

2024-09-10 Thread Roger Pau Monne
Current blkif implementations (both backends and frontends) have all slight differences about how they handle the 'sector-size' xenstore node, and how other fields are derived from this value or hardcoded to be expressed in units of 512 bytes. To give some context, this is an excerpt of how differ