Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-05-02 Thread Marek Marczykowski-Górecki
On Tue, May 02, 2023 at 12:53:15PM +0200, Jan Beulich wrote: > On 25.04.2023 16:39, Marek Marczykowski-Górecki wrote: > > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. > > This sentence is odd, as by

Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-05-02 Thread Jan Beulich
On 25.04.2023 16:39, Marek Marczykowski-Górecki wrote: > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. This sentence is odd, as by its grammar it looks to describe the current situation only. The

Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-04-27 Thread Jan Beulich
On 27.04.2023 01:43, Marek Marczykowski-Górecki wrote: > On Wed, Apr 26, 2023 at 10:24:28AM +0200, Jan Beulich wrote: >> On 26.04.2023 09:48, Roger Pau Monné wrote: >>> On Tue, Apr 25, 2023 at 04:39:02PM +0200, Marek Marczykowski-Górecki wrote: --- a/xen/drivers/char/ns16550.c +++

Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-04-26 Thread Marek Marczykowski-Górecki
On Wed, Apr 26, 2023 at 10:24:28AM +0200, Jan Beulich wrote: > On 26.04.2023 09:48, Roger Pau Monné wrote: > > On Tue, Apr 25, 2023 at 04:39:02PM +0200, Marek Marczykowski-Górecki wrote: > >> --- a/xen/drivers/char/ns16550.c > >> +++ b/xen/drivers/char/ns16550.c > >> @@ -272,7 +272,15 @@ static

Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-04-26 Thread Jan Beulich
On 26.04.2023 09:48, Roger Pau Monné wrote: > On Tue, Apr 25, 2023 at 04:39:02PM +0200, Marek Marczykowski-Górecki wrote: >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -272,7 +272,15 @@ static int cf_check ns16550_getc(struct serial_port >> *port, char *pc) >>

Re: [PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-04-26 Thread Roger Pau Monné
On Tue, Apr 25, 2023 at 04:39:02PM +0200, Marek Marczykowski-Górecki wrote: > pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART > devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. > Note the MMIO-based devices in practice need a "pci" sub-option, > otherwise a

[PATCH v2] ns16550: enable memory decoding on MMIO-based PCI console card

2023-04-25 Thread Marek Marczykowski-Górecki
pci_serial_early_init() enables PCI_COMMAND_IO for IO-based UART devices, add setting PCI_COMMAND_MEMORY for MMIO-based UART devices too. Note the MMIO-based devices in practice need a "pci" sub-option, otherwise a few parameters are not initialized (including bar_idx, reg_shift, reg_width etc).