Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Jan Beulich
On 29.07.2024 14:47, Roger Pau Monné wrote: > On Mon, Jul 29, 2024 at 02:41:23PM +0200, Jan Beulich wrote: >> On 29.07.2024 14:00, Roger Pau Monné wrote: >>> On Mon, Jul 29, 2024 at 12:47:09PM +0200, Jan Beulich wrote: On 29.07.2024 12:30, Roger Pau Monne wrote: > ---

Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Roger Pau Monné
On Mon, Jul 29, 2024 at 02:41:23PM +0200, Jan Beulich wrote: > On 29.07.2024 14:00, Roger Pau Monné wrote: > > On Mon, Jul 29, 2024 at 12:47:09PM +0200, Jan Beulich wrote: > >> On 29.07.2024 12:30, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/alternative.h > >>> +++

Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Jan Beulich
On 29.07.2024 14:00, Roger Pau Monné wrote: > On Mon, Jul 29, 2024 at 12:47:09PM +0200, Jan Beulich wrote: >> On 29.07.2024 12:30, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/alternative.h >>> +++ b/xen/arch/x86/include/asm/alternative.h >>> @@ -183,13 +183,13 @@ extern void

Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Roger Pau Monné
On Mon, Jul 29, 2024 at 12:47:09PM +0200, Jan Beulich wrote: > On 29.07.2024 12:30, Roger Pau Monne wrote: > > --- a/xen/arch/x86/include/asm/alternative.h > > +++ b/xen/arch/x86/include/asm/alternative.h > > @@ -183,13 +183,13 @@ extern void alternative_branches(void); > > *

Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Alejandro Vallejo
On Mon Jul 29, 2024 at 11:47 AM BST, Jan Beulich wrote: > On 29.07.2024 12:30, Roger Pau Monne wrote: > > --- a/xen/arch/x86/include/asm/alternative.h > > +++ b/xen/arch/x86/include/asm/alternative.h > > @@ -183,13 +183,13 @@ extern void alternative_branches(void); > > *

Re: [PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Jan Beulich
On 29.07.2024 12:30, Roger Pau Monne wrote: > --- a/xen/arch/x86/include/asm/alternative.h > +++ b/xen/arch/x86/include/asm/alternative.h > @@ -183,13 +183,13 @@ extern void alternative_branches(void); > * https://github.com/llvm/llvm-project/issues/12579 > *

[PATCH v2] x86/altcall: further refine clang workaround

2024-07-29 Thread Roger Pau Monne
The current code in ALT_CALL_ARG() won't successfully workaround the clang code-generation issue if the arg parameter has a size that's not a power of 2. While there are no such sized parameters at the moment, improve the workaround to also be effective when such sizes are used. Instead of using