Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-25 Thread Srivatsa S. Bhat
Hi Igor and Sean, On 1/20/23 10:35 AM, Sean Christopherson wrote: > On Fri, Jan 20, 2023, Igor Mammedov wrote: >> On Fri, 20 Jan 2023 05:55:11 -0800 >> "Srivatsa S. Bhat" wrote: >> >>> Hi Igor and Thomas, >>> >>> Thank you for your review! >>> >>> On 1/19/23 1:12 PM, Thomas Gleixner wrote:

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-20 Thread Sean Christopherson
On Fri, Jan 20, 2023, Igor Mammedov wrote: > On Fri, 20 Jan 2023 05:55:11 -0800 > "Srivatsa S. Bhat" wrote: > > > Hi Igor and Thomas, > > > > Thank you for your review! > > > > On 1/19/23 1:12 PM, Thomas Gleixner wrote: > > > On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote: > > >>

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-20 Thread Igor Mammedov
On Fri, 20 Jan 2023 05:55:11 -0800 "Srivatsa S. Bhat" wrote: > Hi Igor and Thomas, > > Thank you for your review! > > On 1/19/23 1:12 PM, Thomas Gleixner wrote: > > On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote: > >> "Srivatsa S. Bhat" wrote: > >>> Fix this by preventing the use of

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-20 Thread Srivatsa S. Bhat
Hi Igor and Thomas, Thank you for your review! On 1/19/23 1:12 PM, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote: >> "Srivatsa S. Bhat" wrote: >>> Fix this by preventing the use of mwait idle state in the vCPU offline >>> play_dead() path for any hypervisor, even

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-19 Thread Thomas Gleixner
On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote: > "Srivatsa S. Bhat" wrote: >> Fix this by preventing the use of mwait idle state in the vCPU offline >> play_dead() path for any hypervisor, even if mwait support is >> available. > > if mwait is enabled, it's very likely guest to have cpuidle >

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-16 Thread Igor Mammedov
On Sun, 15 Jan 2023 22:01:34 -0800 "Srivatsa S. Bhat" wrote: > From: "Srivatsa S. Bhat (VMware)" > > Under hypervisors that support mwait passthrough, a vCPU in mwait > CPU-idle state remains in guest context (instead of yielding to the > hypervisor via VMEXIT), which helps speed up wakeups

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-16 Thread Juergen Gross
On 16.01.23 07:01, Srivatsa S. Bhat wrote: From: "Srivatsa S. Bhat (VMware)" Under hypervisors that support mwait passthrough, a vCPU in mwait CPU-idle state remains in guest context (instead of yielding to the hypervisor via VMEXIT), which helps speed up wakeups from idle. However, this runs

[PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-15 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" Under hypervisors that support mwait passthrough, a vCPU in mwait CPU-idle state remains in guest context (instead of yielding to the hypervisor via VMEXIT), which helps speed up wakeups from idle. However, this runs into problems with CPU hotplug, because the