Re: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-04-19 Thread Jan Beulich
On 19.04.2023 15:22, Roger Pau Monné wrote: > On Wed, Apr 19, 2023 at 02:14:44PM +0200, Jan Beulich wrote: >> On 19.04.2023 13:45, Roger Pau Monne wrote: >>> --- a/xen/include/public/vcpu.h >>> +++ b/xen/include/public/vcpu.h >>> @@ -150,7 +150,7 @@ typedef struct vcpu_set_singleshot_timer >>> vcp

Re: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-04-19 Thread Roger Pau Monné
On Wed, Apr 19, 2023 at 02:14:44PM +0200, Jan Beulich wrote: > On 19.04.2023 13:45, Roger Pau Monne wrote: > > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > > When the hypervisor returns -ENOTIME (timeout in the past) Linux keeps > > Nit: -ETIME Oh, thanks. > > > retrying

Re: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-04-19 Thread Jan Beulich
On 19.04.2023 13:45, Roger Pau Monne wrote: > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > When the hypervisor returns -ENOTIME (timeout in the past) Linux keeps Nit: -ETIME > retrying to setup the timer with a higher timeout instead of > self-injecting a timer interrupt. >

RE: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-04-19 Thread Henry Wang
Hi Roger, > -Original Message- > From: Roger Pau Monne > Subject: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future > > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > When the hypervisor returns -ENOTIME (timeout in the past) Linux keeps > retryi

[PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-04-19 Thread Roger Pau Monne
The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. When the hypervisor returns -ENOTIME (timeout in the past) Linux keeps retrying to setup the timer with a higher timeout instead of self-injecting a timer interrupt. On boxes without any hardware assistance for logdirty we have seen