Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-22 Thread Juergen Gross
On 21.02.23 23:42, Julien Grall wrote: Hi Juergen, On 21/02/2023 08:37, Juergen Gross wrote: On 20.02.23 23:50, Julien Grall wrote: +    list_del(>list); +    talloc_free(cd); +    } +} + +void acc_commit(struct connection *conn) +{ +    struct changed_domain *cd; +    struct

Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-21 Thread Julien Grall
Hi Juergen, On 21/02/2023 08:37, Juergen Gross wrote: On 20.02.23 23:50, Julien Grall wrote: +    list_del(>list); +    talloc_free(cd); +    } +} + +void acc_commit(struct connection *conn) +{ +    struct changed_domain *cd; +    struct buffered_data *in = conn->in; +    enum accitem

Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-21 Thread Juergen Gross
On 20.02.23 23:50, Julien Grall wrote: Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole

Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-20 Thread Julien Grall
Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can

[PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-01-20 Thread Juergen Gross
Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can reuse large parts of the per transaction accounting. The