Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-26 Thread Jan Beulich
On 17.07.2023 17:24, Jan Beulich wrote: > On 14.07.2023 11:28, Julien Grall wrote: >> On 11/07/2023 13:29, Jan Beulich wrote: >>> On 10.07.2023 22:59, Julien Grall wrote: > --- > I'm not really certain about XEN_DOMCTL_irq_permission: With pIRQ-s not > used, the prior pIRQ -> IRQ

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-17 Thread Jan Beulich
On 14.07.2023 11:28, Julien Grall wrote: > On 11/07/2023 13:29, Jan Beulich wrote: >> On 10.07.2023 22:59, Julien Grall wrote: --- I'm not really certain about XEN_DOMCTL_irq_permission: With pIRQ-s not used, the prior pIRQ -> IRQ translation cannot have succeeded on Arm, so

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-14 Thread Julien Grall
Hi Jan, On 11/07/2023 13:29, Jan Beulich wrote: On 10.07.2023 22:59, Julien Grall wrote: --- I'm not really certain about XEN_DOMCTL_irq_permission: With pIRQ-s not used, the prior pIRQ -> IRQ translation cannot have succeeded on Arm, so quite possibly the entire domctl is unused there? Yet

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-11 Thread Jan Beulich
On 10.07.2023 22:59, Julien Grall wrote: >> --- >> I'm not really certain about XEN_DOMCTL_irq_permission: With pIRQ-s not >> used, the prior pIRQ -> IRQ translation cannot have succeeded on Arm, so >> quite possibly the entire domctl is unused there? Yet then how is access >> to particular device

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-10 Thread Julien Grall
Hi Jan, On 03/05/2023 16:33, Jan Beulich wrote: ... by way of a new arch-selectable Kconfig control. Note that some smaller pieces of code are left without #ifdef, to keep things better readable. Hence items like ECS_PIRQ, nr_static_irqs, or domain_pirq_to_irq() remain uniformly.

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-10 Thread Julien Grall
Hi, On 04/05/2023 09:21, Jan Beulich wrote: On 04.05.2023 10:13, Roger Pau Monné wrote: On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: On 04.05.2023 09:44, Roger Pau Monné wrote: On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: --- a/xen/include/xen/sched.h +++

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-04 Thread Jan Beulich
On 04.05.2023 10:13, Roger Pau Monné wrote: > On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: >> On 04.05.2023 09:44, Roger Pau Monné wrote: >>> On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-04 Thread Roger Pau Monné
On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: > On 04.05.2023 09:44, Roger Pau Monné wrote: > > On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: > >> --- a/xen/include/xen/sched.h > >> +++ b/xen/include/xen/sched.h > >> @@ -438,12 +438,14 @@ struct domain > >> > >>

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-04 Thread Jan Beulich
On 04.05.2023 09:44, Roger Pau Monné wrote: > On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -438,12 +438,14 @@ struct domain >> >> struct grant_table *grant_table; >> >> +#ifdef CONFIG_HAS_PIRQ >>

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-04 Thread Roger Pau Monné
On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -438,12 +438,14 @@ struct domain > > struct grant_table *grant_table; > > +#ifdef CONFIG_HAS_PIRQ > /* > * Interrupt to event-channel mappings and

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-04 Thread Jan Beulich
On 03.05.2023 17:33, Jan Beulich wrote: > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -683,11 +683,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe > unsigned int pirq = op->u.irq_permission.pirq, irq; > int allow = op->u.irq_permission.allow_access; > > +#ifdef

[PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-03 Thread Jan Beulich
... by way of a new arch-selectable Kconfig control. Note that some smaller pieces of code are left without #ifdef, to keep things better readable. Hence items like ECS_PIRQ, nr_static_irqs, or domain_pirq_to_irq() remain uniformly. Signed-off-by: Jan Beulich --- I'm not really certain about