Re: [PATCH v2 1/3] x86/shadow: move dm-mmio handling code in sh_page_fault()

2023-02-24 Thread Andrew Cooper
On 23/01/2023 3:08 pm, Jan Beulich wrote: > On 23.01.2023 15:26, Jan Beulich wrote: >> Do away with the partly mis-named "mmio" label there, which really is >> only about emulated MMIO. Move the code to the place where the sole >> "goto" was. Re-order steps slightly: Assertion first, perfc

Re: [PATCH v2 1/3] x86/shadow: move dm-mmio handling code in sh_page_fault()

2023-01-23 Thread Jan Beulich
On 23.01.2023 15:26, Jan Beulich wrote: > Do away with the partly mis-named "mmio" label there, which really is > only about emulated MMIO. Move the code to the place where the sole > "goto" was. Re-order steps slightly: Assertion first, perfc increment > outside of the locked region, and "gpa"

[PATCH v2 1/3] x86/shadow: move dm-mmio handling code in sh_page_fault()

2023-01-23 Thread Jan Beulich
Do away with the partly mis-named "mmio" label there, which really is only about emulated MMIO. Move the code to the place where the sole "goto" was. Re-order steps slightly: Assertion first, perfc increment outside of the locked region, and "gpa" calculation closer to the first use of the