Re: [PATCH v2 1/4] x86/vioapic: check IRR before attempting to inject interrupt after EOI

2021-01-21 Thread Roger Pau Monné
On Thu, Jan 21, 2021 at 05:03:51PM +0100, Jan Beulich wrote: > On 15.01.2021 15:28, Roger Pau Monne wrote: > > In vioapic_update_EOI the irq_lock will be dropped in order to forward > > the EOI to the dpci handler, so there's a window between clearing IRR > > and checking if the line is asserted

Re: [PATCH v2 1/4] x86/vioapic: check IRR before attempting to inject interrupt after EOI

2021-01-21 Thread Jan Beulich
On 15.01.2021 15:28, Roger Pau Monne wrote: > In vioapic_update_EOI the irq_lock will be dropped in order to forward > the EOI to the dpci handler, so there's a window between clearing IRR > and checking if the line is asserted where IRR can change behind our > back. > > Fix this by checking

[PATCH v2 1/4] x86/vioapic: check IRR before attempting to inject interrupt after EOI

2021-01-15 Thread Roger Pau Monne
In vioapic_update_EOI the irq_lock will be dropped in order to forward the EOI to the dpci handler, so there's a window between clearing IRR and checking if the line is asserted where IRR can change behind our back. Fix this by checking whether IRR is set before attempting to inject a new