Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-21 Thread Jan Beulich
On 20.07.2022 22:12, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> +static int xue_init_dbc(struct xue *xue) >>> +{ >>> +uint64_t erdp = 0; >>> +uint64_t out = 0; >>> +

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-20 Thread Marek Marczykowski-Górecki
On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > > +static int xue_init_dbc(struct xue *xue) > > +{ > > +uint64_t erdp = 0; > > +uint64_t out = 0; > > +uint64_t in = 0; > > +uint64_t mbs = 0; > > +struct

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-18 Thread Jan Beulich
On 18.07.2022 12:45, Marek Marczykowski-Górecki wrote: > On Tue, Jul 12, 2022 at 05:59:51PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> +static bool __init xue_init_xhc(struct xue *xue) >>> +{ >>> +uint32_t bar0; >>> +uint64_t bar1; >>> +

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-18 Thread Marek Marczykowski-Górecki
On Tue, Jul 12, 2022 at 05:59:51PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: > > > > ###

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-16 Thread Marek Marczykowski-Górecki
On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > > +static int xue_init_dbc(struct xue *xue) > > +{ > > +uint64_t erdp = 0; > > +uint64_t out = 0; > > +uint64_t in = 0; > > +uint64_t mbs = 0; > > +struct

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-16 Thread Marek Marczykowski-Górecki
On Thu, Jul 14, 2022 at 08:05:28AM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > > +struct xue { > > +struct xue_dbc_reg *dbc_reg; > > +struct xue_dbc_ctx *dbc_ctx; > > +struct xue_erst_segment *dbc_erst; > > +struct xue_trb_ring dbc_ering; >

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-14 Thread Jan Beulich
On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > +static int xue_init_dbc(struct xue *xue) > +{ > +uint64_t erdp = 0; > +uint64_t out = 0; > +uint64_t in = 0; > +uint64_t mbs = 0; > +struct xue_dbc_reg *reg = xue_find_dbc(xue); > + > +if ( !reg ) > +return

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-14 Thread Jan Beulich
On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > +struct xue { > +struct xue_dbc_reg *dbc_reg; > +struct xue_dbc_ctx *dbc_ctx; > +struct xue_erst_segment *dbc_erst; > +struct xue_trb_ring dbc_ering; > +struct xue_trb_ring dbc_oring; > +struct xue_trb_ring dbc_iring;

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-12 Thread Jan Beulich
On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > From: Connor Davis > > [Connor] > Xue is a cross-platform USB 3 debugger that drives the Debug > Capability (DbC) of xHCI-compliant host controllers. This patch > implements the operations needed for xue to initialize the host >

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-12 Thread Jan Beulich
On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: > > ### dbgp > > `= ehci[ | @pci:. ]` > +> `= xue` > > Specify the USB

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-07 Thread Marek Marczykowski-Górecki
On Wed, Jul 06, 2022 at 05:32:06PM +0200, Marek Marczykowski-Górecki wrote: > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig > index e5f7b1d8eb8a..d12b2205dafc 100644 > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -74,3 +74,12 @@ config HAS_EHCI >

[PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger

2022-07-06 Thread Marek Marczykowski-Górecki
From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct