Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls

2022-11-10 Thread Ross Philipson
On 11/10/22 13:07, Peter Zijlstra wrote: On Thu, Nov 10, 2022 at 03:45:21PM +, Ross Philipson wrote: On allocation failures, panic() was used since this seemed to be the action taken on other failures in the modules touched by this patch. How is the panic() more useful than the obvious

Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls

2022-11-10 Thread Peter Zijlstra
On Thu, Nov 10, 2022 at 03:45:21PM +, Ross Philipson wrote: > On allocation failures, panic() was used since this seemed > to be the action taken on other failures in the modules > touched by this patch. How is the panic() more useful than the obvious NULL deref that also splats?

[PATCH v2 2/2] x86: Check return values from early_ioremap calls

2022-11-10 Thread Ross Philipson
There are a number of places where early_ioremap is called but the return pointer is not checked for NULL. The call can result in a NULL being returned so the checks must be added. On allocation failures, panic() was used since this seemed to be the action taken on other failures in the modules