Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Jan Beulich
On 18.07.2022 12:08, Julien Grall wrote: > On 18/07/2022 10:31, Jan Beulich wrote: >> On 15.07.2022 19:03, Julien Grall wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) >>> } >>> >>> /*

Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Julien Grall
Hi Jan, On 18/07/2022 10:31, Jan Beulich wrote: On 15.07.2022 19:03, Julien Grall wrote: From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap

Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Julien Grall
On 18/07/2022 09:18, Wei Chen wrote:   static void init_heap_pages(   struct page_info *pg, unsigned long nr_pages)   {   unsigned long i; -    bool idle_scrub = false; +    bool need_scrub = scrub_debug; You have changed idle_scrub to need_scrub, but haven't mentioned this in commi

Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Jan Beulich
On 15.07.2022 19:03, Julien Grall wrote: > From: Julien Grall > > At the moment, init_heap_pages() will call free_heap_pages() page > by page. To reduce the time to initialize the heap, we will want > to provide multiple pages at the same time. > > init_heap_pages() is now split in two parts: >

Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Wei Chen
Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap_pages() is now split in two parts:

[PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-15 Thread Julien Grall
From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap_pages() is now split in two parts: - init_heap_pages(): will break down the range in mul