Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-30 Thread Stefano Stabellini
On Fri, 30 Oct 2020, Julien Grall wrote: > Hi, > > On 30/10/2020 18:28, Stefano Stabellini wrote: > > On Fri, 30 Oct 2020, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 24/10/2020 01:16, Stefano Stabellini wrote: > > > > On Fri, 23 Oct 2020, Julien Grall wrote: > > > > >bool __acpi_unm

Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-30 Thread Julien Grall
Hi, On 30/10/2020 18:28, Stefano Stabellini wrote: On Fri, 30 Oct 2020, Julien Grall wrote: Hi Stefano, On 24/10/2020 01:16, Stefano Stabellini wrote: On Fri, 23 Oct 2020, Julien Grall wrote: bool __acpi_unmap_table(const void *ptr, unsigned long size) { vaddr_t vaddr = (vaddr_t

Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-30 Thread Stefano Stabellini
On Fri, 30 Oct 2020, Julien Grall wrote: > Hi Stefano, > > On 24/10/2020 01:16, Stefano Stabellini wrote: > > On Fri, 23 Oct 2020, Julien Grall wrote: > > > bool __acpi_unmap_table(const void *ptr, unsigned long size) > > > { > > > vaddr_t vaddr = (vaddr_t)ptr; > > > +unsigned int id

Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-30 Thread Julien Grall
Hi Stefano, On 24/10/2020 01:16, Stefano Stabellini wrote: On Fri, 23 Oct 2020, Julien Grall wrote: bool __acpi_unmap_table(const void *ptr, unsigned long size) { vaddr_t vaddr = (vaddr_t)ptr; +unsigned int idx; + +/* We are only handling fixmap address in the arch code */ +

Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-23 Thread Stefano Stabellini
On Fri, 23 Oct 2020, Julien Grall wrote: > From: Julien Grall > > Commit 022387ee1ad3 "xen/arm: mm: Don't open-code Xen PT update in > {set, clear}_fixmap()" enforced that each set_fixmap() should be > paired with a clear_fixmap(). Any failure to follow the model would > result to a platform cras

[PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-23 Thread Julien Grall
From: Julien Grall Commit 022387ee1ad3 "xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap()" enforced that each set_fixmap() should be paired with a clear_fixmap(). Any failure to follow the model would result to a platform crash. Unfortunately, the use of fixmap in the ACPI code