Re: [PATCH v2 3/3] x86/shadow: drop dead code from HVM-only sh_page_fault() pieces

2023-02-24 Thread Andrew Cooper
On 23/01/2023 2:27 pm, Jan Beulich wrote: > The shadow_mode_refcounts() check immediately ahead of the "emulate" > label renders redundant two subsequent is_hvm_domain() checks (the > latter of which was already redundant with the former). > > Also guest_mode() checks are pointless when we already

[PATCH v2 3/3] x86/shadow: drop dead code from HVM-only sh_page_fault() pieces

2023-01-23 Thread Jan Beulich
The shadow_mode_refcounts() check immediately ahead of the "emulate" label renders redundant two subsequent is_hvm_domain() checks (the latter of which was already redundant with the former). Also guest_mode() checks are pointless when we already know we're dealing with a HVM domain. Finally