Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-02 Thread Julien Grall
On 02/11/2023 11:15, Luca Fancellu wrote: Hi Julien, diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c new file mode 100644 index ..dc9c90cf00a7 --- /dev/null +++ b/xen/arch/arm/dom0less-build.c @@ -0,0 +1,1087 @@ +/* SPDX-License-Identifier: GPL-2.0-onl

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-02 Thread Luca Fancellu
Hi Julien, >> diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c >> new file mode 100644 >> index ..dc9c90cf00a7 >> --- /dev/null >> +++ b/xen/arch/arm/dom0less-build.c >> @@ -0,0 +1,1087 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * xen/arc

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-01 Thread Julien Grall
Hi Luca, On 27/09/2023 15:01, Luca Fancellu wrote: Currently the dom0less feature code is mostly inside domain_build.c and setup.c, it is a feature that may not be useful to everyone so put the code in a different compilation module in order to make it easier to disable the feature in the future

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Julien Grall wrote: > On 03/10/2023 21:40, Stefano Stabellini wrote: > > On Tue, 3 Oct 2023, Julien Grall wrote: > > > On 03/10/2023 20:52, Stefano Stabellini wrote: > > > > On Tue, 3 Oct 2023, Michal Orzel wrote: > > > > > On 03/10/2023 09:44, Luca Fancellu wrote: > > > > > > G

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-04 Thread Julien Grall
Hi, On 03/10/2023 21:40, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Julien Grall wrote: On 03/10/2023 20:52, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Michal Orzel wrote: On 03/10/2023 09:44, Luca Fancellu wrote: Given that the status after the move to common of the above functions is

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-03 Thread Stefano Stabellini
On Tue, 3 Oct 2023, Julien Grall wrote: > On 03/10/2023 20:52, Stefano Stabellini wrote: > > On Tue, 3 Oct 2023, Michal Orzel wrote: > > > On 03/10/2023 09:44, Luca Fancellu wrote: > > > > Given that the status after the move to common of the above functions is > > > > not very clean, I’ve decided

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-03 Thread Julien Grall
Hi Stefano, On 03/10/2023 20:52, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Michal Orzel wrote: On 03/10/2023 09:44, Luca Fancellu wrote: Given that the status after the move to common of the above functions is not very clean, I’ve decided to don’t do that, however if you are fine with it,

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-03 Thread Stefano Stabellini
On Tue, 3 Oct 2023, Michal Orzel wrote: > On 03/10/2023 09:44, Luca Fancellu wrote: > > Given that code movement is painful from a git history perspective, and > > given that we have to move dom0less code to xen/common anyway to make > > it available to RISC-V and also x86, could we do

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-03 Thread Michal Orzel
Hi Luca, On 03/10/2023 09:44, Luca Fancellu wrote: > > > Given that code movement is painful from a git history perspective, and > given that we have to move dom0less code to xen/common anyway to make > it available to RISC-V and also x86, could we do it in one shot here? L

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-03 Thread Luca Fancellu
Given that code movement is painful from a git history perspective, and given that we have to move dom0less code to xen/common anyway to make it available to RISC-V and also x86, could we do it in one shot here? >>> >>> Looking at the name of the functions, I would expect that we w

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-02 Thread Stefano Stabellini
On Mon, 2 Oct 2023, Bertrand Marquis wrote: > > On 2 Oct 2023, at 10:26, Julien Grall wrote: > > On 29/09/2023 20:48, Stefano Stabellini wrote: > >> On Fri, 29 Sep 2023, Luca Fancellu wrote: > On 29 Sep 2023, at 01:33, Stefano Stabellini > wrote: > > On Wed, 27 Sep 2023, Luc

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-02 Thread Bertrand Marquis
Hi, > On 2 Oct 2023, at 10:26, Julien Grall wrote: > > Hi Stefano, > > On 29/09/2023 20:48, Stefano Stabellini wrote: >> On Fri, 29 Sep 2023, Luca Fancellu wrote: On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: On Wed, 27 Sep 2023, Luca Fancellu wrote: > Currently

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-02 Thread Julien Grall
Hi Stefano, On 29/09/2023 20:48, Stefano Stabellini wrote: On Fri, 29 Sep 2023, Luca Fancellu wrote: On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: On Wed, 27 Sep 2023, Luca Fancellu wrote: Currently the dom0less feature code is mostly inside domain_build.c and setup.c, it is a feature

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Luca Fancellu wrote: > > On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: > > > > On Wed, 27 Sep 2023, Luca Fancellu wrote: > >> Currently the dom0less feature code is mostly inside domain_build.c > >> and setup.c, it is a feature that may not be useful to everyone so > >>

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-29 Thread Luca Fancellu
Hi Stefano, > On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Luca Fancellu wrote: >> Currently the dom0less feature code is mostly inside domain_build.c >> and setup.c, it is a feature that may not be useful to everyone so >> put the code in a different compilation

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-28 Thread Stefano Stabellini
On Wed, 27 Sep 2023, Luca Fancellu wrote: > Currently the dom0less feature code is mostly inside domain_build.c > and setup.c, it is a feature that may not be useful to everyone so > put the code in a different compilation module in order to make it > easier to disable the feature in the future. >

[PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-27 Thread Luca Fancellu
Currently the dom0less feature code is mostly inside domain_build.c and setup.c, it is a feature that may not be useful to everyone so put the code in a different compilation module in order to make it easier to disable the feature in the future. Move gic_interrupt_t in domain_build.h to use it wi