Re: [PATCH v2 3/5] x86/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Andrew Cooper
On 22/11/2023 9:27 am, Jan Beulich wrote: > On 21.11.2023 21:15, Andrew Cooper wrote: >> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but all >> this work is useless; it's making a memory allocation just to prepend the >> image name which cmdline_cook() intentionally

Re: [PATCH v2 3/5] x86/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Jan Beulich
On 21.11.2023 21:15, Andrew Cooper wrote: > -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but all > this work is useless; it's making a memory allocation just to prepend the > image name which cmdline_cook() intentionally strips back out. > > Simply forgo the work and

[PATCH v2 3/5] x86/efi: Simplify efi_arch_handle_cmdline()

2023-11-21 Thread Andrew Cooper
-Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but all this work is useless; it's making a memory allocation just to prepend the image name which cmdline_cook() intentionally strips back out. Simply forgo the work and identify EFI_LOADER as one of the loaders which doesn't