RE: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, January 27, 2022 10:50 PM > > The VT-d hook can indicate an error, which shouldn't be ignored. Convert > the hook's return value to a proper error code, and let that bubble up. > > Signed-off-by: Jan Beulich > --- > I'm not convinced of the XSM related

Re: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:49, Jan Beulich wrote: The VT-d hook can indicate an error, which shouldn't be ignored. Convert the hook's return value to a proper error code, and let that bubble up. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

[PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure

2022-01-27 Thread Jan Beulich
The VT-d hook can indicate an error, which shouldn't be ignored. Convert the hook's return value to a proper error code, and let that bubble up. Signed-off-by: Jan Beulich --- I'm not convinced of the XSM related behavior here: It's neither clear why the check gets performed on the possible