Re: [PATCH v2 4/4] x86/cpuid: Fix handling of xsave dynamic leaves

2024-05-02 Thread Andrew Cooper
On 02/05/2024 2:04 pm, Jan Beulich wrote: > On 29.04.2024 20:28, Andrew Cooper wrote: >> If max leaf is greater than 0xd but xsave not available to the guest, then >> the >> current XSAVE size should not be filled in. This is a latent bug for now as >> the guest max leaf is 0xd, but will become p

Re: [PATCH v2 4/4] x86/cpuid: Fix handling of xsave dynamic leaves

2024-05-02 Thread Jan Beulich
On 29.04.2024 20:28, Andrew Cooper wrote: > If max leaf is greater than 0xd but xsave not available to the guest, then the > current XSAVE size should not be filled in. This is a latent bug for now as > the guest max leaf is 0xd, but will become problematic in the future. Why would this not be an

[PATCH v2 4/4] x86/cpuid: Fix handling of xsave dynamic leaves

2024-04-29 Thread Andrew Cooper
If max leaf is greater than 0xd but xsave not available to the guest, then the current XSAVE size should not be filled in. This is a latent bug for now as the guest max leaf is 0xd, but will become problematic in the future. The comment concerning XSS state is wrong. VT-x doesn't manage host/gue