Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-08 Thread Alejandro Vallejo
On Mon, Aug 07, 2023 at 06:48:13PM +0100, Julien Grall wrote: > Hi Alex, > > One more remark in the title. s/HAS// as you renamed the Kconfig. > > [snip] > > -- > Julien Grall Oops. Good catch, cheers.

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-07 Thread Jan Beulich
On 07.08.2023 18:06, Alejandro Vallejo wrote: > An alt-patching series can probably make it very close to the perf win of > this patch as long as it transforms the conversion hunks into no-ops when > there's no hole. I looked into the 2018 patch, and I don't think it tried > to go that far (afaics

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-07 Thread Julien Grall
Hi Alex, One more remark in the title. s/HAS// as you renamed the Kconfig. On 28/07/2023 08:59, Alejandro Vallejo wrote: Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related code/data. It also shorts the pdx<->pfn conversion macros and creates stu

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-07 Thread Alejandro Vallejo
Hi, A few days have passed. May I suggest taking a step back? On Tue, Aug 01, 2023 at 09:57:57AM +0200, Jan Beulich wrote: > On 31.07.2023 19:38, Andrew Cooper wrote: > > There's one system which never made its way into production, > > support-for-which in the no-op case is causing a 10% perf hit

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-01 Thread Jan Beulich
On 31.07.2023 19:38, Andrew Cooper wrote: > On 31/07/2023 9:00 am, Jan Beulich wrote: >> On 28.07.2023 18:58, Andrew Cooper wrote: >>> On 28/07/2023 5:36 pm, Andrew Cooper wrote: On 28/07/2023 8:59 am, Alejandro Vallejo wrote: > Adds a new compile-time flag to allow disabling pdx compressi

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-31 Thread Andrew Cooper
On 31/07/2023 9:00 am, Jan Beulich wrote: > On 28.07.2023 18:58, Andrew Cooper wrote: >> On 28/07/2023 5:36 pm, Andrew Cooper wrote: >>> On 28/07/2023 8:59 am, Alejandro Vallejo wrote: Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related cod

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-31 Thread Jan Beulich
On 28.07.2023 09:59, Alejandro Vallejo wrote: > --- a/xen/common/pdx.c > +++ b/xen/common/pdx.c > @@ -31,11 +31,15 @@ unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( > > bool __mfn_valid(unsigned long mfn) > { > -if ( unlikely(evaluate_nospec(mfn >= max_page)) ) > +bool inval

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-31 Thread Julien Grall
On 28/07/2023 17:36, Andrew Cooper wrote: On 28/07/2023 8:59 am, Alejandro Vallejo wrote: Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related code/data. It also shorts the pdx<->pfn conversion macros and creates stubs for masking fucntions. Wh

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-31 Thread Jan Beulich
On 28.07.2023 18:58, Andrew Cooper wrote: > On 28/07/2023 5:36 pm, Andrew Cooper wrote: >> On 28/07/2023 8:59 am, Alejandro Vallejo wrote: >>> Adds a new compile-time flag to allow disabling pdx compression and >>> compiles out compression-related code/data. It also shorts the pdx<->pfn >>> convers

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-28 Thread Andrew Cooper
On 28/07/2023 5:36 pm, Andrew Cooper wrote: > On 28/07/2023 8:59 am, Alejandro Vallejo wrote: >> Adds a new compile-time flag to allow disabling pdx compression and >> compiles out compression-related code/data. It also shorts the pdx<->pfn >> conversion macros and creates stubs for masking fucntio

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-28 Thread Andrew Cooper
On 28/07/2023 8:59 am, Alejandro Vallejo wrote: > Adds a new compile-time flag to allow disabling pdx compression and > compiles out compression-related code/data. It also shorts the pdx<->pfn > conversion macros and creates stubs for masking fucntions. > > While at it, removes the old arch-defined

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-28 Thread Julien Grall
Hi, On 28/07/2023 08:59, Alejandro Vallejo wrote: diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h index 5a82b6bde2..dfb475c8dc 100644 --- a/xen/include/xen/pdx.h +++ b/xen/include/xen/pdx.h @@ -67,8 +67,6 @@ * region involved. */ -#ifdef CONFIG_HAS_PDX - extern unsigned lo

[PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-07-28 Thread Alejandro Vallejo
Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related code/data. It also shorts the pdx<->pfn conversion macros and creates stubs for masking fucntions. While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was not removable in practice