Re: [PATCH v2 5/8] x86/gdbsx: convert "user" to "guest" accesses

2021-02-22 Thread Roger Pau Monné
On Mon, Feb 22, 2021 at 04:55:03PM +0100, Jan Beulich wrote: > On 22.02.2021 16:31, Roger Pau Monné wrote: > > On Wed, Feb 17, 2021 at 09:21:36AM +0100, Jan Beulich wrote: > >> Using copy_{from,to}_user(), this code was assuming to be called only by > >> PV guests. Use copy_{from,to}_guest()

Re: [PATCH v2 5/8] x86/gdbsx: convert "user" to "guest" accesses

2021-02-22 Thread Jan Beulich
On 22.02.2021 16:31, Roger Pau Monné wrote: > On Wed, Feb 17, 2021 at 09:21:36AM +0100, Jan Beulich wrote: >> Using copy_{from,to}_user(), this code was assuming to be called only by >> PV guests. Use copy_{from,to}_guest() instead, transforming the incoming >> structure field into a guest handle

Re: [PATCH v2 5/8] x86/gdbsx: convert "user" to "guest" accesses

2021-02-22 Thread Roger Pau Monné
On Wed, Feb 17, 2021 at 09:21:36AM +0100, Jan Beulich wrote: > Using copy_{from,to}_user(), this code was assuming to be called only by > PV guests. Use copy_{from,to}_guest() instead, transforming the incoming > structure field into a guest handle (the field should really have been > one in the

[PATCH v2 5/8] x86/gdbsx: convert "user" to "guest" accesses

2021-02-17 Thread Jan Beulich
Using copy_{from,to}_user(), this code was assuming to be called only by PV guests. Use copy_{from,to}_guest() instead, transforming the incoming structure field into a guest handle (the field should really have been one in the first place). Also do not transform the debuggee address into a