[PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-09 Thread Olaf Hering
xl migrate --debug used to track every pfn in every batch of pages. Since commit cfa955591caea5d7ec505cdcbf4442f2d6e889e1 from Xen 4.6 the debug flag changed meaning from "verify transferred memory during live migration" to "verify transferred memory in remus/colo". At least xl will not be able to

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-09 Thread Ian Jackson
Olaf Hering writes ("[PATCH v20210209 4/4] xl: disable --debug option for xl migrate"): > xl migrate --debug used to track every pfn in every batch of pages. > > Since commit cfa955591caea5d7ec505cdcbf4442f2d6e889e1 from Xen 4.6 the > debug flag changed meaning from &quo

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-09 Thread Olaf Hering
Am Tue, 9 Feb 2021 17:12:28 + schrieb Ian Jackson : > Also, Olaf, please CC Andy on these migration-related patches. Can this be automated via MAINTAINERS, so that scripts/get_maintainer.pl addresses the people who feel responsible for it? Right now it ends up in your queue due to 'tools/*'

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-10 Thread Olaf Hering
Am Tue, 9 Feb 2021 17:12:28 + schrieb Ian Jackson : > It seems to me that something is definitely a bug here but I want to > understand from Andy what the best thing to do is. I'm hesitant to > release-ack removing this at this stage. > > Wouldn't it be better to just fix the docs like in yo

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-10 Thread Olaf Hering
Am Wed, 10 Feb 2021 10:06:06 +0100 schrieb Olaf Hering : > -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) > +if ( ctx->save.debug ) This will do the verification, and finds many errors: 2021-02-10 02:37:03 MST [2149] xc: error: verify pfn 0xfda9 failed (type 0): Internal