Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-29 Thread Henry Wang
Hi Stefano, > On Sep 28, 2023, at 08:40, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Bertrand Marquis wrote: >>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >>> >> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c >> index 695d2fa1f1..2a8527cacc 100644 >> --- a/xen/

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-28 Thread Bertrand Marquis
> On 28 Sep 2023, at 02:40, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Bertrand Marquis wrote: >>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >>> >> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c >> index 695d2fa1f1..2a8527cacc 100644 >> --- a/xen/arch/arm/ps

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Stefano Stabellini
On Wed, 27 Sep 2023, Bertrand Marquis wrote: > > On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: > > > >>> > diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c > >>> > index 695d2fa1f1..2a8527cacc 100644 > >>> > --- a/xen/arch/arm/psci.c > >>> > +++ b/xen/arch/arm/psci.c > >>> > @@ -59,6 +59,

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Luca Fancellu
> On 27 Sep 2023, at 09:35, Bertrand Marquis wrote: > > Hi Jan, > >> On 27 Sep 2023, at 10:23, Jan Beulich wrote: >> >> On 27.09.2023 10:14, Bertrand Marquis wrote: On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: My opinion is that it's far easier for this to be an eclair co

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Bertrand Marquis
Hi Jan, > On 27 Sep 2023, at 10:23, Jan Beulich wrote: > > On 27.09.2023 10:14, Bertrand Marquis wrote: >>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >>> My opinion is that it's far easier for this to be an eclair configuration >>> (which has the >>> advantage not to depend on the exact

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Jan Beulich
On 27.09.2023 10:14, Bertrand Marquis wrote: >> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >> My opinion is that it's far easier for this to be an eclair configuration >> (which has the >> advantage not to depend on the exact definition of unreachable) and then >> perhaps a comment >> above

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Bertrand Marquis
Hi, > On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: > >>> > diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c >>> > index 695d2fa1f1..2a8527cacc 100644 >>> > --- a/xen/arch/arm/psci.c >>> > +++ b/xen/arch/arm/psci.c >>> > @@ -59,6 +59,7 @@ void call_psci_cpu_off(void) >>> > } >>> >

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-27 Thread Nicola Vetrini
> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c > index 695d2fa1f1..2a8527cacc 100644 > --- a/xen/arch/arm/psci.c > +++ b/xen/arch/arm/psci.c > @@ -59,6 +59,7 @@ void call_psci_cpu_off(void) > } > } > +/* SAF-2-safe */ I think any use of SAF-2-safe should be accompanied with an

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Julien Grall wrote: > Hi Stefano, > > On 09/09/2023 00:03, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptance of Rule 2.1, we > > decided on a few exceptions that were not properly recorded in > > rules.rst. Add t

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Jan Beulich wrote: > On 09.09.2023 01:03, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptance of Rule 2.1, we > > decided on a few exceptions that were not properly recorded in > > rules.rst. Add them now. > > > >

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Julien Grall
Hi Stefano, On 09/09/2023 00:03, Stefano Stabellini wrote: From: Stefano Stabellini During the discussions that led to the acceptance of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini Acked-by: Jan Beulic

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Jan Beulich
On 09.09.2023 01:03, Stefano Stabellini wrote: > From: Stefano Stabellini > > During the discussions that led to the acceptance of Rule 2.1, we > decided on a few exceptions that were not properly recorded in > rules.rst. Add them now. > > Signed-off-by: Stefano Stabellini > Acked-by: Jan Beuli

[PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-08 Thread Stefano Stabellini
From: Stefano Stabellini During the discussions that led to the acceptance of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich --- Nicola, does this work with ECLAIR? I am referring to