Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Andrew Cooper
On 16/02/2023 1:36 pm, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/16/23 12:28, Andrew Cooper wrote: >> On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: >>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> index 234da4a7f4..97d6b810ec 100644 >>>

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Xenia Ragiadakou
Hi Andrew, On 2/16/23 12:28, Andrew Cooper wrote: On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f4..97d6b810ec 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Andrew Cooper
On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > index 234da4a7f4..97d6b810ec 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -85,7 +85,7 @@

RE: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-15 Thread Tian, Kevin
> From: Xenia Ragiadakou > Sent: Monday, February 13, 2023 7:50 PM > > APIC virtualization support is currently implemented only for Intel VT-x. > To aid future work on separating AMD-V from Intel VT-x code, instead of > calling directly vmx_vlapic_msr_changed() from common hvm code, add a >

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-13 Thread Jan Beulich
On 13.02.2023 12:50, Xenia Ragiadakou wrote: > APIC virtualization support is currently implemented only for Intel VT-x. > To aid future work on separating AMD-V from Intel VT-x code, instead of > calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub > to the

[PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-13 Thread Xenia Ragiadakou
APIC virtualization support is currently implemented only for Intel VT-x. To aid future work on separating AMD-V from Intel VT-x code, instead of calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub to the hvm_function_table, named update_vlapic_mode, and create a wrapper