RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-24 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for > Arm > >>> Correct, I agree. I added a numa_init_distance() function (in patch #12) > >>> to > >>> set all va

Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-24 Thread Jan Beulich
On 24.04.2023 13:02, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >> On 23.04.2023 07:36, Henry Wang wrote: -Original Message- From: Jan Beulich >> However, looking at the code below, don't you mean to have the array >> pre-set to all NUMA_NO_D

RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-24 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for > Arm > > On 23.04.2023 07:36, Henry Wang wrote: > >> -Original Message- > >> From: Jan Beulich > >>>

RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-24 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for > Arm > > > Thanks for the explanation! I think I now understand :) Would this diff > below > > look good to you then? Apprec

Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-24 Thread Jan Beulich
On 23.04.2023 07:36, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich However, looking at the code below, don't you mean to have the array pre-set to all NUMA_NO_DISTANCE? >>> >>> ...I am a bit puzzled about why pre-setting the array to all >>> NUMA_NO_DISTANCE matter

RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-22 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for > Arm > >> However, looking at the code below, don't you mean to have the array > >> pre-set to all NUMA_NO_DISTANCE? > >

Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-21 Thread Jan Beulich
On 21.04.2023 11:23, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >>> --- a/xen/arch/arm/numa.c >>> +++ b/xen/arch/arm/numa.c >>> @@ -28,6 +28,11 @@ enum dt_numa_status { >>> >>> static enum dt_numa_status __ro_after_init device_tree_numa = >> DT_NUMA_DEFAULT; >>> >>> +

RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-21 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for > Arm > > As both x86 and Arm have implemented __node_distance, so we move > > its definition from asm/numa.h to xen/numa.h. > > Ni

Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-20 Thread Jan Beulich
On 20.04.2023 13:25, Henry Wang wrote: > From: Wei Chen > > We will parse NUMA nodes distances from device tree. So we need > a matrix to record the distances between any two nodes we parsed. > Accordingly, we provide this node_set_distance API for device tree > NUMA to set the distance for any t

[PATCH v3 03/17] xen/arm: implement node distance helpers for Arm

2023-04-20 Thread Henry Wang
From: Wei Chen We will parse NUMA nodes distances from device tree. So we need a matrix to record the distances between any two nodes we parsed. Accordingly, we provide this node_set_distance API for device tree NUMA to set the distance for any two nodes in this patch. When NUMA initialization fa