Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-24 Thread Jan Beulich
On 24.11.2020 11:22, Julien Grall wrote: > On 24/11/2020 09:47, Jan Beulich wrote: >> On 23.11.2020 18:13, Julien Grall wrote: >>> My view on 2) can change if Jan provides enough information into why one >>> would want NS1650 PCI enabled by default on Arm but disable MSI. >> >> Because, like it was

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-24 Thread Julien Grall
Hi Jan, On 24/11/2020 09:47, Jan Beulich wrote: On 23.11.2020 18:13, Julien Grall wrote: My view on 2) can change if Jan provides enough information into why one would want NS1650 PCI enabled by default on Arm but disable MSI. Because, like it was on x86, initially there may be no support for

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-24 Thread Jan Beulich
On 23.11.2020 18:13, Julien Grall wrote: > My view on 2) can change if Jan provides enough information into why one > would want NS1650 PCI enabled by default on Arm but disable MSI. Because, like it was on x86, initially there may be no support for MSI? I have no idea what the plans are ... Jan

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-23 Thread Stefano Stabellini
On Mon, 23 Nov 2020, Jan Beulich wrote: > Rahul, > > On 23.11.2020 12:54, Rahul Singh wrote: > > Hello Jan, > > as an aside - it helps if you also put the addressee of your mail > on the To list. > > >> On 20 Nov 2020, at 12:14 am, Stefano Stabellini > >> wrote: > >> > >> On Thu, 19 Nov 2020,

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-23 Thread Julien Grall
Hi Stefano, On 20/11/2020 00:14, Stefano Stabellini wrote: On Thu, 19 Nov 2020, Julien Grall wrote: On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, wrote: On Thu, 19 Nov 2020, Rahul Singh wrote: > > On 19/11/2020 09:53, Jan Beulich wrote: > >> On 19.11.2020 10:21, Julien Gr

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-23 Thread Jan Beulich
Rahul, On 23.11.2020 12:54, Rahul Singh wrote: > Hello Jan, as an aside - it helps if you also put the addressee of your mail on the To list. >> On 20 Nov 2020, at 12:14 am, Stefano Stabellini >> wrote: >> >> On Thu, 19 Nov 2020, Julien Grall wrote: >>> On Thu, 19 Nov 2020, 23:38 Stefano Stabe

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-23 Thread Rahul Singh
Hello Jan, > On 20 Nov 2020, at 12:14 am, Stefano Stabellini > wrote: > > On Thu, 19 Nov 2020, Julien Grall wrote: >> On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, >> wrote: >> On Thu, 19 Nov 2020, Rahul Singh wrote: On 19/11/2020 09:53, Jan Beulich wrote: > On 19.11.2020 10:21

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2020, Julien Grall wrote: > On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, wrote: > On Thu, 19 Nov 2020, Rahul Singh wrote: > > > On 19/11/2020 09:53, Jan Beulich wrote: > > >> On 19.11.2020 10:21, Julien Grall wrote: > > >>> Hi Jan, > > >>> > > >

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Julien Grall
On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, wrote: > On Thu, 19 Nov 2020, Rahul Singh wrote: > > > On 19/11/2020 09:53, Jan Beulich wrote: > > >> On 19.11.2020 10:21, Julien Grall wrote: > > >>> Hi Jan, > > >>> > > >>> On 19/11/2020 09:05, Jan Beulich wrote: > > On 18.11.2020 16:50, Julie

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2020, Rahul Singh wrote: > > On 19/11/2020 09:53, Jan Beulich wrote: > >> On 19.11.2020 10:21, Julien Grall wrote: > >>> Hi Jan, > >>> > >>> On 19/11/2020 09:05, Jan Beulich wrote: > On 18.11.2020 16:50, Julien Grall wrote: > > On 16/11/2020 12:25, Rahul Singh wrote: >

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Jan Beulich
On 19.11.2020 16:54, Rahul Singh wrote: >> On 19 Nov 2020, at 10:16 am, Julien Grall wrote: >> On 19/11/2020 09:53, Jan Beulich wrote: >>> Well, see my patch suppressing building of quite a part of it. >> >> I will let Rahul figuring out whether your patch series is sufficient to fix >> compilati

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Rahul Singh
Hello, > On 19 Nov 2020, at 10:16 am, Julien Grall wrote: > > > > On 19/11/2020 09:53, Jan Beulich wrote: >> On 19.11.2020 10:21, Julien Grall wrote: >>> Hi Jan, >>> >>> On 19/11/2020 09:05, Jan Beulich wrote: On 18.11.2020 16:50, Julien Grall wrote: > On 16/11/2020 12:25, Rahul Sing

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Julien Grall
On 19/11/2020 09:53, Jan Beulich wrote: On 19.11.2020 10:21, Julien Grall wrote: Hi Jan, On 19/11/2020 09:05, Jan Beulich wrote: On 18.11.2020 16:50, Julien Grall wrote: On 16/11/2020 12:25, Rahul Singh wrote: NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enab

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Jan Beulich
On 19.11.2020 10:21, Julien Grall wrote: > Hi Jan, > > On 19/11/2020 09:05, Jan Beulich wrote: >> On 18.11.2020 16:50, Julien Grall wrote: >>> On 16/11/2020 12:25, Rahul Singh wrote: NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enabled for ARM, compilation e

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Julien Grall
Hi Jan, On 19/11/2020 09:00, Jan Beulich wrote: On 18.11.2020 16:35, Julien Grall wrote: On 18/11/2020 15:16, Jan Beulich wrote: On 18.11.2020 16:02, Rahul Singh wrote: Hello Jan, On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: On 16.11.2020 13:25, Rahul Singh wrote: NS16550 driver has P

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Julien Grall
Hi Jan, On 19/11/2020 09:05, Jan Beulich wrote: On 18.11.2020 16:50, Julien Grall wrote: On 16/11/2020 12:25, Rahul Singh wrote: NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enabled for ARM, compilation error is observed for ARM architecture because ARM platforms

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Jan Beulich
On 18.11.2020 16:50, Julien Grall wrote: > On 16/11/2020 12:25, Rahul Singh wrote: >> NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI >> is enabled for ARM, compilation error is observed for ARM architecture >> because ARM platforms do not have full PCI support available. >

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Jan Beulich
On 18.11.2020 16:35, Julien Grall wrote: > On 18/11/2020 15:16, Jan Beulich wrote: >> On 18.11.2020 16:02, Rahul Singh wrote: >>> Hello Jan, >>> On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: On 16.11.2020 13:25, Rahul Singh wrote: > NS16550 driver has PCI support that is under

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Jan Beulich
On 18.11.2020 16:35, Julien Grall wrote: > So even we are going to enable PCI on Arm and fix compilation issue, > there are no way the NS16550 PCI would be usuable without effort for a > few reasons: > >1) com1/com2 is x86 specific >2) ns16550_init() is not used by Arm and the only way t

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-18 Thread Julien Grall
Hi Rahul, On 16/11/2020 12:25, Rahul Singh wrote: NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enabled for ARM, compilation error is observed for ARM architecture because ARM platforms do not have full PCI support available. > Introducing new kconfig option CONFIG

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-18 Thread Julien Grall
Hi, On 18/11/2020 15:16, Jan Beulich wrote: On 18.11.2020 16:02, Rahul Singh wrote: Hello Jan, On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: On 16.11.2020 13:25, Rahul Singh wrote: NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enabled for ARM, compilation err

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-18 Thread Jan Beulich
On 18.11.2020 16:02, Rahul Singh wrote: > Hello Jan, > >> On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: >> >> On 16.11.2020 13:25, Rahul Singh wrote: >>> NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI >>> is enabled for ARM, compilation error is observed for ARM archite

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-18 Thread Rahul Singh
Hello Jan, > On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: > > On 16.11.2020 13:25, Rahul Singh wrote: >> NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI >> is enabled for ARM, compilation error is observed for ARM architecture >> because ARM platforms do not have full

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-17 Thread Jan Beulich
On 16.11.2020 13:25, Rahul Singh wrote: > NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI > is enabled for ARM, compilation error is observed for ARM architecture > because ARM platforms do not have full PCI support available. While you've extended the sentence, it remains

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-16 Thread Stefano Stabellini
On Mon, 16 Nov 2020, Rahul Singh wrote: > NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI > is enabled for ARM, compilation error is observed for ARM architecture > because ARM platforms do not have full PCI support available. > > Introducing new kconfig option CONFIG_HAS_N

[PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-16 Thread Rahul Singh
NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI is enabled for ARM, compilation error is observed for ARM architecture because ARM platforms do not have full PCI support available. Introducing new kconfig option CONFIG_HAS_NS16550_PCI to support ns16550 PCI for X86. For X8