Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-05-03 Thread Jan Beulich
On 03.05.2023 01:29, Jennifer Herbert wrote: > On 02/05/2023 14:41, Jan Beulich wrote: >> On 25.04.2023 19:47, Jennifer Herbert wrote: >>> --- a/tools/libacpi/acpi2_0.h >>> +++ b/tools/libacpi/acpi2_0.h >>> @@ -121,6 +121,36 @@ struct acpi_20_tcpa { >>> }; >>> #define ACPI_2_0_TCPA_LAML_SIZE (6

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-05-02 Thread Jennifer Herbert
On 02/05/2023 14:41, Jan Beulich wrote: On 25.04.2023 19:47, Jennifer Herbert wrote: --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -121,6 +121,36 @@ struct acpi_20_tcpa { }; #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) +/* + * TPM2 + */ Nit: While I'm willing to accept the

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-05-02 Thread Jan Beulich
On 25.04.2023 19:47, Jennifer Herbert wrote: > --- a/tools/libacpi/acpi2_0.h > +++ b/tools/libacpi/acpi2_0.h > @@ -121,6 +121,36 @@ struct acpi_20_tcpa { > }; > #define ACPI_2_0_TCPA_LAML_SIZE (64*1024) > > +/* > + * TPM2 > + */ Nit: While I'm willing to accept the comment style violation here

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-04-27 Thread Jennifer Herbert
On 26/04/2023 21:29, Jason Andryuk wrote: On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert wrote: This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- ... diff --git a/to

Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-04-26 Thread Jason Andryuk
On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert wrote: > > This patch introduces an optional TPM 2 interface definition to the ACPI > table, > which is to be used as part of a vTPM 2 implementation. > > Signed-off-by: Jennifer Herbert > --- ... > diff --git a/tools/firmware/hvmloader/util.c b/t

[PATCH v3 2/2] acpi: Add TPM2 interface definition.

2023-04-25 Thread Jennifer Herbert
This patch introduces an optional TPM 2 interface definition to the ACPI table, which is to be used as part of a vTPM 2 implementation. Signed-off-by: Jennifer Herbert --- docs/misc/xenstore-paths.pandoc | 3 ++- tools/firmware/hvmloader/util.c | 9 tools/libacpi/Makefile |