Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
On Wed, 2023-03-01 at 15:21 +, Julien Grall wrote: > Hi Oleksii, > > On 01/03/2023 15:16, Oleksii wrote: > > On Wed, 2023-03-01 at 13:58 +, Julien Grall wrote: > > > On 01/03/2023 12:31, Oleksii wrote: > > > Given this is an alignment issue (Arm32 is more sensible to this > > > than > > >

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
Hi Julien, > On 01/03/2023 15:16, Oleksii wrote: > > On Wed, 2023-03-01 at 13:58 +, Julien Grall wrote: > > > On 01/03/2023 12:31, Oleksii wrote: > > > Given this is an alignment issue (Arm32 is more sensible to this > > > than > > > the other architecture, but this is still a potential

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Julien Grall
Hi Oleksii, On 01/03/2023 15:16, Oleksii wrote: On Wed, 2023-03-01 at 13:58 +, Julien Grall wrote: On 01/03/2023 12:31, Oleksii wrote: Given this is an alignment issue (Arm32 is more sensible to this than the other architecture, but this is still a potential problem for the other archs), I

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
On Wed, 2023-03-01 at 13:58 +, Julien Grall wrote: > On 01/03/2023 12:31, Oleksii wrote: > > Hi Julien, > > Hi, > > > > > > > > > > > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > > > > > The following changes were made: > > > > > > > * make GENERIC_BUG_FRAME mandatory for ARM > > >

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Julien Grall
On 01/03/2023 12:31, Oleksii wrote: Hi Julien, Hi, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM I have asked in patch #1 but will ask it again because I think this should be recorded in the commit message. Can

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
On Wed, 2023-03-01 at 09:31 +, Julien Grall wrote: > Hi, > > On 01/03/2023 08:58, Oleksii wrote: > > On Tue, 2023-02-28 at 17:48 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 28/02/2023 15:09, Oleksii wrote: > > > > On Sat, 2023-02-25 at 16:49 +, Julien Grall wrote: > > > >

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
Hi Julien, > > > > > > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > > > The following changes were made: > > > > > * make GENERIC_BUG_FRAME mandatory for ARM > > > > > > > > I have asked in patch #1 but will ask it again because I think > > > > this > > > > should be recorded in the

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Julien Grall
Hi, On 01/03/2023 08:58, Oleksii wrote: On Tue, 2023-02-28 at 17:48 +, Julien Grall wrote: Hi Oleksii, On 28/02/2023 15:09, Oleksii wrote: On Sat, 2023-02-25 at 16:49 +, Julien Grall wrote: Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: *

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-01 Thread Oleksii
On Tue, 2023-02-28 at 17:48 +, Julien Grall wrote: > Hi Oleksii, > > On 28/02/2023 15:09, Oleksii wrote: > > On Sat, 2023-02-25 at 16:49 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > > The following changes were made: > > > > *

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-28 Thread Julien Grall
On 28/02/2023 17:21, Oleksii wrote: Hi Julien, Hi Oleksii, On Sat, 2023-02-25 at 17:05 +, Julien Grall wrote: On 25/02/2023 16:49, Julien Grall wrote: Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: * make GENERIC_BUG_FRAME mandatory for

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-28 Thread Julien Grall
Hi Oleksii, On 28/02/2023 15:09, Oleksii wrote: On Sat, 2023-02-25 at 16:49 +, Julien Grall wrote: Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM I have asked in patch #1 but will ask it again because

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-28 Thread Oleksii
Hi Julien, On Sat, 2023-02-25 at 17:05 +, Julien Grall wrote: > > > On 25/02/2023 16:49, Julien Grall wrote: > > Hi Oleksii, > > > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > The following changes were made: > > > * make GENERIC_BUG_FRAME mandatory for ARM > > > > I have asked in

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-28 Thread Oleksii
Hi Julien, On Sat, 2023-02-25 at 16:49 +, Julien Grall wrote: > Hi Oleksii, > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > The following changes were made: > > * make GENERIC_BUG_FRAME mandatory for ARM > > I have asked in patch #1 but will ask it again because I think this > should

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-25 Thread Julien Grall
On 25/02/2023 16:49, Julien Grall wrote: Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM I have asked in patch #1 but will ask it again because I think this should be recorded in the commit message. Can

Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-25 Thread Julien Grall
Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM I have asked in patch #1 but will ask it again because I think this should be recorded in the commit message. Can you outline why it is not possible to

[PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-02-24 Thread Oleksii Kurochko
The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM * As do_bug_frame() returns -EINVAL in case something goes wrong otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was updated to check if the returned value is less than 0 * Change macros bug_file()