Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-17 Thread Jan Beulich
On 11.05.2022 16:21, Bertrand Marquis wrote: >> On 11 May 2022, at 13:11, George Dunlap wrote: >>> On May 11, 2022, at 9:34 AM, Julien Grall wrote: >>> On 11/05/2022 07:30, Lin Liu (刘林) wrote: On 10/05/2022 11:15, Lin Liu wrote: > static inline void put_unaligned_be16(uint16_t val, void

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Bertrand Marquis
Hi George, > On 11 May 2022, at 13:11, George Dunlap wrote: > > > >> On May 11, 2022, at 9:34 AM, Julien Grall wrote: >> >> Hi, >> >> Please configure your e-mail client to send in plain text. >> >> On 11/05/2022 07:30, Lin Liu (刘林)

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Bertrand Marquis
Hi, > On 11 May 2022, at 04:12, Stefano Stabellini wrote: > > On Tue, 10 May 2022, Julien Grall wrote: >>> It is not reasonable to say "this unrelated thing is broken, and you >>> need to fix it first to get your series in". Requests like that are, >>> I'm sure, part of what Bertrand raised in

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Julien Grall
Hi George, On 11/05/2022 13:11, George Dunlap wrote: Google told me __force is used in linux kernel to suppress warning in sparse, https://stackoverflow.com/questions/53120610/what-does-the-attribute-force-do Is sparse also used in xen? I am not aware of any use of Sparse in Xen, but it would

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread George Dunlap
> On May 11, 2022, at 9:34 AM, Julien Grall wrote: > > Hi, > > Please configure your e-mail client to send in plain text. > > On 11/05/2022 07:30, Lin Liu (刘林) wrote: >> Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap >> On 10/05/2022 11:15, Lin Liu wro

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Julien Grall
On 11/05/2022 10:56, Andrew Cooper wrote: On 10/05/2022 12:47, Julien Grall wrote: Hi, On 10/05/2022 12:34, Andrew Cooper wrote: On 10/05/2022 12:17, Julien Grall wrote: diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..16b2e6f5f0 100644 --- a/xen

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Andrew Cooper
On 10/05/2022 12:47, Julien Grall wrote: > Hi, > > On 10/05/2022 12:34, Andrew Cooper wrote: >> On 10/05/2022 12:17, Julien Grall wrote: > >> diff --git a/xen/include/xen/unaligned.h >> b/xen/include/xen/unaligned.h >> index 0a2b16d05d..16b2e6f5f0 100644 >> --- a/xen/includ

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Julien Grall
Hi, Please configure your e-mail client to send in plain text. On 11/05/2022 07:30, Lin Liu (刘林) wrote: Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap On 10/05/2022 11:15, Lin Liu wrote: Update to use byteswap to swap bytes. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-11 Thread Julien Grall
Hi, On 11/05/2022 04:12, Stefano Stabellini wrote: Alternatively, I also think that taking this patch as is without alignment fix (either using be16_to_cpu or be16_to_cpup) is fine. The alignment could be fixed afterwards. The key is that I think it should be one of the maintainers to write the

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Stefano Stabellini
On Tue, 10 May 2022, Julien Grall wrote: > > It is not reasonable to say "this unrelated thing is broken, and you > > need to fix it first to get your series in".  Requests like that are, > > I'm sure, part of what Bertrand raised in the community call as > > unnecessary fiction getting work submit

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Anthony PERARD
On Tue, May 10, 2022 at 06:15:22AM -0400, Lin Liu wrote: > Update to use byteswap to swap bytes. > > No functional change. > > Signed-off-by: Lin Liu FYI, this patch breaks build of stubdomain: In file included from /var/tmp/git.xen.lU52/stubdom/include/../../xen/common/unxz.c:124,

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Julien Grall
Hi, On 10/05/2022 12:34, Andrew Cooper wrote: On 10/05/2022 12:17, Julien Grall wrote: diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..16b2e6f5f0 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -20,62 +20,62 @@      sta

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Andrew Cooper
On 10/05/2022 12:17, Julien Grall wrote: >> >>> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..16b2e6f5f0 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -20,62 +20,62 @@      static inline uint16_

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Julien Grall
Hi, On 10/05/2022 12:09, Andrew Cooper wrote: On 10/05/2022 11:51, Julien Grall wrote: On 10/05/2022 11:15, Lin Liu wrote: diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..70d3be3be6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -171,

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Andrew Cooper
On 10/05/2022 11:51, Julien Grall wrote: > On 10/05/2022 11:15, Lin Liu wrote: >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index 4aae281e89..70d3be3be6 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -171,7 +171,7 @@ bool_t dt_property_rea

Re: [PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Julien Grall
Hi, On 10/05/2022 11:15, Lin Liu wrote: Update to use byteswap to swap bytes. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Changes in v3: - Update xen/common/device_tree.c to use

[PATCH v3 4/6] xen: Switch to byteswap

2022-05-10 Thread Lin Liu
Update to use byteswap to swap bytes. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Changes in v3: - Update xen/common/device_tree.c to use be32_to_cpu - Keep const in type cast in un