RE: [PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-06 Thread Tian, Kevin
> From: Roger Pau Monne > Sent: Tuesday, September 1, 2020 6:55 PM > > From: Andrew Cooper > > Change the catch-all behavior for MSR not explicitly handled. Instead > of allow full read-access to the MSR space and silently dropping > writes return an exception when the MSR is not explicitly han

Re: [PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-04 Thread Roger Pau Monné
On Fri, Sep 04, 2020 at 10:53:26AM +0200, Jan Beulich wrote: > On 01.09.2020 12:54, Roger Pau Monne wrote: > > @@ -3290,11 +3288,6 @@ static int vmx_msr_write_intercept(unsigned int msr, > > uint64_t msr_content) > > __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); > > break; > > >

Re: [PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-04 Thread Andrew Cooper
On 04/09/2020 09:53, Jan Beulich wrote: > On 01.09.2020 12:54, Roger Pau Monne wrote: >> @@ -3290,11 +3288,6 @@ static int vmx_msr_write_intercept(unsigned int msr, >> uint64_t msr_content) >> __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); >> break; >> >> -case MSR_IA32_FEATU

Re: [PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-04 Thread Jan Beulich
On 04.09.2020 11:44, Andrew Cooper wrote: > On 04/09/2020 09:53, Jan Beulich wrote: >> On 01.09.2020 12:54, Roger Pau Monne wrote: >>> @@ -3290,11 +3288,6 @@ static int vmx_msr_write_intercept(unsigned int msr, >>> uint64_t msr_content) >>> __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); >>>

Re: [PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-04 Thread Jan Beulich
On 01.09.2020 12:54, Roger Pau Monne wrote: > @@ -3290,11 +3288,6 @@ static int vmx_msr_write_intercept(unsigned int msr, > uint64_t msr_content) > __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); > break; > > -case MSR_IA32_FEATURE_CONTROL: > -case MSR_IA32_VMX_BASIC ... M

[PATCH v3 7/8] x86/hvm: Disallow access to unknown MSRs

2020-09-01 Thread Roger Pau Monne
From: Andrew Cooper Change the catch-all behavior for MSR not explicitly handled. Instead of allow full read-access to the MSR space and silently dropping writes return an exception when the MSR is not explicitly handled. Signed-off-by: Andrew Cooper [remove rdmsr_safe from default case in svm_