Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-04 Thread Michał Leszczyński
- 3 lip 2020 o 9:58, Julien Grall jul...@xen.org napisał(a): > Hi, > > On 02/07/2020 21:28, Michał Leszczyński wrote: >> - 2 lip 2020 o 16:31, Julien Grall jul...@xen.org napisał(a): >> >>> On 02/07/2020 15:17, Jan Beulich wrote: On 02.07.2020 16:14, Julien Grall wrote: > On

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-03 Thread Julien Grall
Hi, On 02/07/2020 21:28, Michał Leszczyński wrote: - 2 lip 2020 o 16:31, Julien Grall jul...@xen.org napisał(a): On 02/07/2020 15:17, Jan Beulich wrote: On 02.07.2020 16:14, Julien Grall wrote: On 02/07/2020 14:30, Jan Beulich wrote: On 02.07.2020 11:57, Julien Grall wrote: On

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Michał Leszczyński
- 2 lip 2020 o 10:34, Jan Beulich jbeul...@suse.com napisał(a): > On 02.07.2020 10:10, Roger Pau Monné wrote: >> On Wed, Jul 01, 2020 at 10:42:55PM +0100, Andrew Cooper wrote: >>> On 30/06/2020 13:33, Michał Leszczyński wrote: diff --git a/xen/arch/x86/hvm/vmx/vmcs.c

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Michał Leszczyński
- 2 lip 2020 o 16:31, Julien Grall jul...@xen.org napisał(a): > On 02/07/2020 15:17, Jan Beulich wrote: >> On 02.07.2020 16:14, Julien Grall wrote: >>> On 02/07/2020 14:30, Jan Beulich wrote: On 02.07.2020 11:57, Julien Grall wrote: > On 02/07/2020 10:18, Jan Beulich wrote: >> On

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Julien Grall
On 02/07/2020 15:17, Jan Beulich wrote: On 02.07.2020 16:14, Julien Grall wrote: On 02/07/2020 14:30, Jan Beulich wrote: On 02.07.2020 11:57, Julien Grall wrote: On 02/07/2020 10:18, Jan Beulich wrote: On 02.07.2020 10:54, Julien Grall wrote: On 02/07/2020 09:50, Jan Beulich wrote: On

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 02.07.2020 16:14, Julien Grall wrote: > Hi, > > On 02/07/2020 14:30, Jan Beulich wrote: >> On 02.07.2020 11:57, Julien Grall wrote: >>> Hi, >>> >>> On 02/07/2020 10:18, Jan Beulich wrote: On 02.07.2020 10:54, Julien Grall wrote: > > > On 02/07/2020 09:50, Jan Beulich wrote:

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Julien Grall
Hi, On 02/07/2020 14:30, Jan Beulich wrote: On 02.07.2020 11:57, Julien Grall wrote: Hi, On 02/07/2020 10:18, Jan Beulich wrote: On 02.07.2020 10:54, Julien Grall wrote: On 02/07/2020 09:50, Jan Beulich wrote: On 02.07.2020 10:42, Julien Grall wrote: On 02/07/2020 09:29, Jan Beulich

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 02.07.2020 11:57, Julien Grall wrote: > Hi, > > On 02/07/2020 10:18, Jan Beulich wrote: >> On 02.07.2020 10:54, Julien Grall wrote: >>> >>> >>> On 02/07/2020 09:50, Jan Beulich wrote: On 02.07.2020 10:42, Julien Grall wrote: > On 02/07/2020 09:29, Jan Beulich wrote: >> I'm with

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Julien Grall
Hi, On 02/07/2020 10:18, Jan Beulich wrote: On 02.07.2020 10:54, Julien Grall wrote: On 02/07/2020 09:50, Jan Beulich wrote: On 02.07.2020 10:42, Julien Grall wrote: On 02/07/2020 09:29, Jan Beulich wrote: I'm with Andrew here, fwiw, as long as the little bit of code that is actually put

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 02.07.2020 10:54, Julien Grall wrote: > > > On 02/07/2020 09:50, Jan Beulich wrote: >> On 02.07.2020 10:42, Julien Grall wrote: >>> On 02/07/2020 09:29, Jan Beulich wrote: I'm with Andrew here, fwiw, as long as the little bit of code that is actually put in common/ or include/xen/

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Julien Grall
On 02/07/2020 09:50, Jan Beulich wrote: On 02.07.2020 10:42, Julien Grall wrote: On 02/07/2020 09:29, Jan Beulich wrote: I'm with Andrew here, fwiw, as long as the little bit of code that is actually put in common/ or include/xen/ doesn't imply arbitrary restrictions on acceptable values.

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 02.07.2020 10:42, Julien Grall wrote: > On 02/07/2020 09:29, Jan Beulich wrote: >> I'm with Andrew here, fwiw, as long as the little bit of code that >> is actually put in common/ or include/xen/ doesn't imply arbitrary >> restrictions on acceptable values. > Well yes the code is simple.

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Julien Grall
Hi Jan, On 02/07/2020 09:29, Jan Beulich wrote: On 01.07.2020 20:09, Julien Grall wrote: On 01/07/2020 19:06, Andrew Cooper wrote: On 01/07/2020 19:02, Julien Grall wrote: On 01/07/2020 18:26, Andrew Cooper wrote: For the sake of what is literally just one byte in common code, I stand my

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 02.07.2020 10:10, Roger Pau Monné wrote: > On Wed, Jul 01, 2020 at 10:42:55PM +0100, Andrew Cooper wrote: >> On 30/06/2020 13:33, Michał Leszczyński wrote: >>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c >>> index ca94c2bedc..b73d824357 100644 >>> ---

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Jan Beulich
On 01.07.2020 20:09, Julien Grall wrote: > On 01/07/2020 19:06, Andrew Cooper wrote: >> On 01/07/2020 19:02, Julien Grall wrote: >>> On 01/07/2020 18:26, Andrew Cooper wrote: For the sake of what is literally just one byte in common code, I stand my original suggestion of this being a

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-02 Thread Roger Pau Monné
On Wed, Jul 01, 2020 at 10:42:55PM +0100, Andrew Cooper wrote: > On 30/06/2020 13:33, Michał Leszczyński wrote: > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > > index ca94c2bedc..b73d824357 100644 > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Andrew Cooper
On 30/06/2020 13:33, Michał Leszczyński wrote: > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index ca94c2bedc..b73d824357 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -291,6 +291,12 @@ static int vmx_init_vmcs_config(void) >

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Julien Grall
On 01/07/2020 19:06, Andrew Cooper wrote: On 01/07/2020 19:02, Julien Grall wrote: Hi, On 01/07/2020 18:26, Andrew Cooper wrote: On 01/07/2020 17:18, Julien Grall wrote: On 01/07/2020 17:17, Julien Grall wrote: On 01/07/2020 17:06, Andrew Cooper wrote: On 01/07/2020 16:12, Julien

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Andrew Cooper
On 01/07/2020 19:02, Julien Grall wrote: > Hi, > > On 01/07/2020 18:26, Andrew Cooper wrote: >> On 01/07/2020 17:18, Julien Grall wrote: >>> >>> >>> On 01/07/2020 17:17, Julien Grall wrote: On 01/07/2020 17:06, Andrew Cooper wrote: > On 01/07/2020 16:12, Julien Grall wrote:

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Julien Grall
Hi, On 01/07/2020 18:26, Andrew Cooper wrote: On 01/07/2020 17:18, Julien Grall wrote: On 01/07/2020 17:17, Julien Grall wrote: On 01/07/2020 17:06, Andrew Cooper wrote: On 01/07/2020 16:12, Julien Grall wrote: On 30/06/2020 13:33, Michał Leszczyński wrote: @@ -305,7 +311,6 @@ static

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Andrew Cooper
On 01/07/2020 17:18, Julien Grall wrote: > > > On 01/07/2020 17:17, Julien Grall wrote: >> >> >> On 01/07/2020 17:06, Andrew Cooper wrote: >>> On 01/07/2020 16:12, Julien Grall wrote: On 30/06/2020 13:33, Michał Leszczyński wrote: > @@ -305,7 +311,6 @@ static int

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Julien Grall
On 01/07/2020 17:17, Julien Grall wrote: On 01/07/2020 17:06, Andrew Cooper wrote: On 01/07/2020 16:12, Julien Grall wrote: On 30/06/2020 13:33, Michał Leszczyński wrote: @@ -305,7 +311,6 @@ static int vmx_init_vmcs_config(void)   SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS |   

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Julien Grall
On 01/07/2020 17:06, Andrew Cooper wrote: On 01/07/2020 16:12, Julien Grall wrote: On 30/06/2020 13:33, Michał Leszczyński wrote: @@ -305,7 +311,6 @@ static int vmx_init_vmcs_config(void) SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES |    

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Andrew Cooper
On 01/07/2020 16:12, Julien Grall wrote: > On 30/06/2020 13:33, Michał Leszczyński wrote: >> @@ -305,7 +311,6 @@ static int vmx_init_vmcs_config(void) >> SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | >> SECONDARY_EXEC_XSAVES | >>

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Julien Grall
On 30/06/2020 13:33, Michał Leszczyński wrote: @@ -305,7 +311,6 @@ static int vmx_init_vmcs_config(void) SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES | SECONDARY_EXEC_TSC_SCALING); -rdmsrl(MSR_IA32_VMX_MISC,

Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-07-01 Thread Roger Pau Monné
On Tue, Jun 30, 2020 at 02:33:45PM +0200, Michał Leszczyński wrote: > From: Michal Leszczynski > > Check if Intel Processor Trace feature is supported by current > processor. Define vmtrace_supported global variable. > > Signed-off-by: Michal Leszczynski > --- > xen/arch/x86/hvm/vmx/vmcs.c

[PATCH v4 02/10] x86/vmx: add IPT cpu feature

2020-06-30 Thread Michał Leszczyński
From: Michal Leszczynski Check if Intel Processor Trace feature is supported by current processor. Define vmtrace_supported global variable. Signed-off-by: Michal Leszczynski --- xen/arch/x86/hvm/vmx/vmcs.c | 7 ++- xen/common/domain.c | 2 ++