Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Michał Leszczyński
- 7 lip 2020 o 13:21, Jan Beulich jbeul...@suse.com napisał(a): > On 07.07.2020 13:17, Michał Leszczyński wrote: >> So would it be OK to use uint32_t everywhere and to store the trace buffer >> size as number of kB? I think this is the most straightforward option. >> >> I would also stick

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Jan Beulich
On 07.07.2020 13:17, Michał Leszczyński wrote: > So would it be OK to use uint32_t everywhere and to store the trace buffer > size as number of kB? I think this is the most straightforward option. > > I would also stick with the name "processor_trace_buf_size" > everywhere, both in the

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Michał Leszczyński
- 7 lip 2020 o 11:16, Julien Grall jul...@xen.org napisał(a): > On 07/07/2020 10:10, Jan Beulich wrote: >> On 07.07.2020 10:44, Julien Grall wrote: >>> Hi, >>> >>> On 06/07/2020 09:46, Jan Beulich wrote: On 04.07.2020 19:23, Julien Grall wrote: > Hi, > > On 03/07/2020 11:11,

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Julien Grall
On 07/07/2020 10:10, Jan Beulich wrote: On 07.07.2020 10:44, Julien Grall wrote: Hi, On 06/07/2020 09:46, Jan Beulich wrote: On 04.07.2020 19:23, Julien Grall wrote: Hi, On 03/07/2020 11:11, Roger Pau Monné wrote: On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: On

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Jan Beulich
On 07.07.2020 10:44, Julien Grall wrote: > Hi, > > On 06/07/2020 09:46, Jan Beulich wrote: >> On 04.07.2020 19:23, Julien Grall wrote: >>> Hi, >>> >>> On 03/07/2020 11:11, Roger Pau Monné wrote: On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: > On 03.07.2020 11:44, Roger Pau

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-07 Thread Julien Grall
Hi, On 06/07/2020 09:46, Jan Beulich wrote: On 04.07.2020 19:23, Julien Grall wrote: Hi, On 03/07/2020 11:11, Roger Pau Monné wrote: On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: On 03.07.2020 11:44, Roger Pau Monné wrote: On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-06 Thread Jan Beulich
On 04.07.2020 19:23, Julien Grall wrote: > Hi, > > On 03/07/2020 11:11, Roger Pau Monné wrote: >> On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: >>> On 03.07.2020 11:44, Roger Pau Monné wrote: On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote: > - 2 lip

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-04 Thread Julien Grall
Hi, On 30/06/2020 13:33, Michał Leszczyński wrote: diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index 71709dc585..891e8e28d6 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -438,6 +438,14 @@ */ #define LIBXL_HAVE_CREATEINFO_PASSTHROUGH 1 +/* + *

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-04 Thread Julien Grall
Hi, On 03/07/2020 11:11, Roger Pau Monné wrote: On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: On 03.07.2020 11:44, Roger Pau Monné wrote: On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote: - 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-03 Thread Roger Pau Monné
On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote: > On 03.07.2020 11:44, Roger Pau Monné wrote: > > On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote: > >> - 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com napisał(a): > >> > >>> On Tue, Jun 30, 2020 at

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-03 Thread Jan Beulich
On 03.07.2020 11:44, Roger Pau Monné wrote: > On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote: >> - 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com napisał(a): >> >>> On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: diff --git

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-03 Thread Roger Pau Monné
On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote: > - 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com napisał(a): > > > On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: > >> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-02 Thread Michał Leszczyński
- 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com napisał(a): > On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: >> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >> index 59bdc28c89..7b8289d436 100644 >> --- a/xen/include/public/domctl.h >>

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-02 Thread Anthony PERARD
Hi Michał, On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: > From: Michal Leszczynski > > Allow to specify the size of per-vCPU trace buffer upon > domain creation. This is zero by default (meaning: not enabled). > > Signed-off-by: Michal Leszczynski > --- > > diff --git

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-02 Thread Roger Pau Monné
On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 59bdc28c89..7b8289d436 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -92,6 +92,7 @@ struct

Re: [PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-07-01 Thread Roger Pau Monné
On Tue, Jun 30, 2020 at 02:33:46PM +0200, Michał Leszczyński wrote: > From: Michal Leszczynski > > Allow to specify the size of per-vCPU trace buffer upon > domain creation. This is zero by default (meaning: not enabled). > > Signed-off-by: Michal Leszczynski > --- > docs/man/xl.cfg.5.pod.in

[PATCH v4 03/10] tools/libxl: add vmtrace_pt_size parameter

2020-06-30 Thread Michał Leszczyński
From: Michal Leszczynski Allow to specify the size of per-vCPU trace buffer upon domain creation. This is zero by default (meaning: not enabled). Signed-off-by: Michal Leszczynski --- docs/man/xl.cfg.5.pod.in | 10 ++ tools/golang/xenlight/helpers.gen.go | 2 ++