[PATCH v4 06/10] tools/libguest: Make setting MTRR registers unconditional

2024-06-26 Thread Alejandro Vallejo
This greatly simplifies a later patch that makes use of HVM contexts to upload LAPIC data. The idea is to reuse MTRR setting procedure to avoid code duplication. It's currently only used for PVH, but there's no real reason to overcomplicate the toolstack preventing them being set for HVM too when h

Re: [PATCH v4 06/10] tools/libguest: Make setting MTRR registers unconditional

2024-06-27 Thread Jan Beulich
On 26.06.2024 18:28, Alejandro Vallejo wrote: > This greatly simplifies a later patch that makes use of HVM contexts to upload > LAPIC data. The idea is to reuse MTRR setting procedure to avoid code > duplication. It's currently only used for PVH, but there's no real reason to > overcomplicate the

Re: [PATCH v4 06/10] tools/libguest: Make setting MTRR registers unconditional

2024-06-27 Thread Alejandro Vallejo
On Thu Jun 27, 2024 at 10:42 AM BST, Jan Beulich wrote: > On 26.06.2024 18:28, Alejandro Vallejo wrote: > > This greatly simplifies a later patch that makes use of HVM contexts to > > upload > > LAPIC data. The idea is to reuse MTRR setting procedure to avoid code > > duplication. It's currently o

Re: [PATCH v4 06/10] tools/libguest: Make setting MTRR registers unconditional

2024-06-27 Thread Jan Beulich
On 27.06.2024 14:02, Alejandro Vallejo wrote: > On Thu Jun 27, 2024 at 10:42 AM BST, Jan Beulich wrote: >> Plus what about a guest which was configured to have the CPUID bit for MTRRs >> clear? >> I think we ought to document this as not supported for PVH (we may > > By "this" do you mean PVH _mus