Re: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables()

2023-08-10 Thread Henry Wang
Hi Julien, > On Aug 9, 2023, at 20:28, Julien Grall wrote: > > Hi Henry, > > Title: NIT: It is more a fold rather than move. You are correct, using “fold” here is more appropriate. > > On 01/08/2023 04:44, Henry Wang wrote: >> For the >> future MPU support work, the early UART mapping could

Re: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables()

2023-08-09 Thread Julien Grall
Hi Henry, Title: NIT: It is more a fold rather than move. On 01/08/2023 04:44, Henry Wang wrote: For the future MPU support work, the early UART mapping could then be moved in prepare_early_mappings(). I would drop this sentence as this is more related to the future implementation of MPU ra

[PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables()

2023-07-31 Thread Henry Wang
The original assembly setup_fixmap() is actually doing two seperate tasks, one is enabling the early UART when earlyprintk on, and the other is to set up the fixmap (even when earlyprintk is off). Per discussion in [1], since commit 9d267c049d92 ("xen/arm64: Rework the memory layout"), there is no