Re: [PATCH v4 2/6] x86/debugger: separate Xen and guest debugging debugger_trap_* functions

2021-09-28 Thread Andrew Cooper
On 28/09/2021 21:30, Bobby Eshleman wrote: > diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c > index e60af16ddd..772e2a5bfc 100644 > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -858,13 +858,20 @@ static void do_trap(struct cpu_user_regs *regs) > if ( regs->error_code

[PATCH v4 2/6] x86/debugger: separate Xen and guest debugging debugger_trap_* functions

2021-09-28 Thread Bobby Eshleman
The functions debugger_trap_fatal(), debugger_trap_immediate(), and debugger_trap_entry() are generic hook functions for debugger support. In practice, debugger_trap_fatal() and debugger_trap_immediate() are only used in the debugging of Xen itself and debugger_trap_entry() is only used in the debu