Re: [PATCH v4 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found

2023-05-11 Thread Andrew Cooper
On 11/05/2023 11:41 am, Jan Beulich wrote: > On 09.05.2023 18:07, Alejandro Vallejo wrote: >> --- a/xen/common/domctl.c >> +++ b/xen/common/domctl.c >> @@ -314,7 +314,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) >> u_domctl) >> /* fall through */ >> default: >>

Re: [PATCH v4 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found

2023-05-11 Thread Jan Beulich
On 09.05.2023 18:07, Alejandro Vallejo wrote: > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -314,7 +314,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > /* fall through */ > default: > d = rcu_lock_domain_by_id(op->domain); > -if

[PATCH v4 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found

2023-05-09 Thread Alejandro Vallejo
It previously mimicked the getdomaininfo sysctl semantics by returning the first domid higher than the requested domid that does exist. This unintuitive behaviour causes quite a few mistakes and makes the call needlessly slow in its error path. This patch removes the fallback search, returning