Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-09 Thread Jan Beulich
On 08.01.2024 22:21, Stefano Stabellini wrote: > On Mon, 8 Jan 2024, Carlo Nonato wrote: >> Hi Jan, >> >> On Mon, Jan 8, 2024 at 5:40 PM Jan Beulich wrote: >>> >>> On 08.01.2024 17:31, Carlo Nonato wrote: On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: > On 08/01/2024 15:18, Carlo

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Stefano Stabellini
On Mon, 8 Jan 2024, Carlo Nonato wrote: > Hi Jan, > > On Mon, Jan 8, 2024 at 5:40 PM Jan Beulich wrote: > > > > On 08.01.2024 17:31, Carlo Nonato wrote: > > > On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: > > >> On 08/01/2024 15:18, Carlo Nonato wrote: > > No. I am saying that that we

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Jan, On Mon, Jan 8, 2024 at 5:40 PM Jan Beulich wrote: > > On 08.01.2024 17:31, Carlo Nonato wrote: > > On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: > >> On 08/01/2024 15:18, Carlo Nonato wrote: > No. I am saying that that we should not be able to allow changing the > colors

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Julien Grall
Hi Carlo, On 08/01/2024 16:31, Carlo Nonato wrote: On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: Hi, On 08/01/2024 15:18, Carlo Nonato wrote: No. I am saying that that we should not be able to allow changing the colors after the memory has been allocated. To give an example, your

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Jan Beulich
On 08.01.2024 17:31, Carlo Nonato wrote: > On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: >> On 08/01/2024 15:18, Carlo Nonato wrote: No. I am saying that that we should not be able to allow changing the colors after the memory has been allocated. To give an example, your

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien, On Mon, Jan 8, 2024 at 4:32 PM Julien Grall wrote: > > Hi, > > On 08/01/2024 15:18, Carlo Nonato wrote: > >> No. I am saying that that we should not be able to allow changing the > >> colors after the memory has been allocated. To give an example, your > >> current code would allow: >

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Julien Grall
Hi, On 08/01/2024 15:18, Carlo Nonato wrote: No. I am saying that that we should not be able to allow changing the colors after the memory has been allocated. To give an example, your current code would allow: 1) Setup the P2M pools or allocate RAM 2) Set the color This would render

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien On Mon, Jan 8, 2024 at 12:36 PM Julien Grall wrote: > > Hi Carlo, > > On 08/01/2024 11:19, Carlo Nonato wrote: > > Hi Julien, > > > > On Mon, Jan 8, 2024 at 12:01 PM Julien Grall wrote: > >> > >> Hi Carlo, > >> > >> On 08/01/2024 10:27, Carlo Nonato wrote: > >>> On Fri, Jan 5, 2024 at

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Julien Grall
Hi Carlo, On 08/01/2024 11:19, Carlo Nonato wrote: Hi Julien, On Mon, Jan 8, 2024 at 12:01 PM Julien Grall wrote: Hi Carlo, On 08/01/2024 10:27, Carlo Nonato wrote: On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: On 02/01/2024 09:51, Carlo Nonato wrote: This commit updates the

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Jan, On Mon, Jan 8, 2024 at 9:43 AM Jan Beulich wrote: > > On 02.01.2024 10:51, Carlo Nonato wrote: > > --- a/xen/arch/arm/llc-coloring.c > > +++ b/xen/arch/arm/llc-coloring.c > > @@ -9,6 +9,7 @@ > > *Carlo Nonato > > */ > > #include > > +#include > > #include > > #include > >

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien, On Mon, Jan 8, 2024 at 12:01 PM Julien Grall wrote: > > Hi Carlo, > > On 08/01/2024 10:27, Carlo Nonato wrote: > > On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: > >> On 02/01/2024 09:51, Carlo Nonato wrote: > >>> This commit updates the domctl interface to allow the user to set

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Julien Grall
Hi Carlo, On 08/01/2024 10:27, Carlo Nonato wrote: On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: On 02/01/2024 09:51, Carlo Nonato wrote: This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien, On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: > > Hi Carlo, > > On 02/01/2024 09:51, Carlo Nonato wrote: > > This commit updates the domctl interface to allow the user to set cache > > coloring configurations from the toolstack. > > It also implements the functionality for arm64.

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Jan Beulich
On 02.01.2024 10:51, Carlo Nonato wrote: > --- a/xen/arch/arm/llc-coloring.c > +++ b/xen/arch/arm/llc-coloring.c > @@ -9,6 +9,7 @@ > *Carlo Nonato > */ > #include > +#include > #include > #include > #include > @@ -278,6 +279,22 @@ int dom0_set_llc_colors(struct domain *d) >

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the functionality for arm64. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato

[PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-02 Thread Carlo Nonato
This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the functionality for arm64. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v5: - added a new hypercall