Re: [PATCH v5 09/10] x86/mm: Reject invalid cacheability in PV guests by default

2022-12-22 Thread Jan Beulich
On 22.12.2022 10:55, Demi Marie Obenour wrote: > On Thu, Dec 22, 2022 at 10:48:02AM +0100, Jan Beulich wrote: >> Also wasn't there talk of having this behavior in debug hypervisors >> only? Without that restriction I'm yet less happy with the change ... > > My understanding was that Andrew

Re: [PATCH v5 09/10] x86/mm: Reject invalid cacheability in PV guests by default

2022-12-22 Thread Demi Marie Obenour
On Thu, Dec 22, 2022 at 10:48:02AM +0100, Jan Beulich wrote: > On 20.12.2022 02:07, Demi Marie Obenour wrote: > > --- a/xen/arch/x86/mm.c > > +++ b/xen/arch/x86/mm.c > > @@ -145,6 +145,8 @@ > > > > #ifdef CONFIG_PV > > #include "pv/mm.h" > > +bool allow_invalid_cacheability; > > static and

Re: [PATCH v5 09/10] x86/mm: Reject invalid cacheability in PV guests by default

2022-12-22 Thread Jan Beulich
On 20.12.2022 02:07, Demi Marie Obenour wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -145,6 +145,8 @@ > > #ifdef CONFIG_PV > #include "pv/mm.h" > +bool allow_invalid_cacheability; static and __ro_after_init please (the former not the least with Misra in mind). >

[PATCH v5 09/10] x86/mm: Reject invalid cacheability in PV guests by default

2022-12-19 Thread Demi Marie Obenour
Setting cacheability flags that are not ones specified by Xen is a bug in the guest. By default, inject #GP into any guest that does this. allow_invalid_cacheability can be used on the Xen command line to disable this check. Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour ---