Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-18 Thread Marek Marczykowski-Górecki
On Tue, May 17, 2022 at 05:46:07PM +0200, Jan Beulich wrote: > On 17.05.2022 17:43, Roger Pau Monné wrote: > > On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: > >> On 17.05.2022 16:48, Roger Pau Monné wrote: > >>> On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > On 1

Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-17 Thread Jan Beulich
On 17.05.2022 17:43, Roger Pau Monné wrote: > On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: >> On 17.05.2022 16:48, Roger Pau Monné wrote: >>> On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > --- a/xen/driv

Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-17 Thread Roger Pau Monné
On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: > On 17.05.2022 16:48, Roger Pau Monné wrote: > > On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > >> On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > >>> --- a/xen/drivers/char/ns16550.c > >>> +++ b/xen/drivers/char

Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-17 Thread Jan Beulich
On 17.05.2022 16:48, Roger Pau Monné wrote: > On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: >> On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/char/ns16550.c >>> +++ b/xen/drivers/char/ns16550.c >>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *u

Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-17 Thread Roger Pau Monné
On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t > > skip_amt, unsigned int idx) >

Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-17 Thread Jan Beulich
On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, > unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), >

[PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff

2022-05-11 Thread Marek Marczykowski-Górecki
Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off