Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-11 Thread Jan Beulich
On 11.07.2025 09:25, dm...@proton.me wrote: > On Fri, Jul 11, 2025 at 07:59:27AM +0200, Jan Beulich wrote: >> On 11.07.2025 03:07, dm...@proton.me wrote: >>> On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: On 10.07.2025 03:35, dm...@proton.me wrote: > @@ -877,6 +873,16 @@ stru

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-11 Thread dmkhn
On Fri, Jul 11, 2025 at 07:59:27AM +0200, Jan Beulich wrote: > On 11.07.2025 03:07, dm...@proton.me wrote: > > On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: > >> On 10.07.2025 03:35, dm...@proton.me wrote: > >>> @@ -877,6 +873,16 @@ struct domain *domain_create(domid_t domid, > >>> >

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-10 Thread Jan Beulich
On 11.07.2025 03:07, dm...@proton.me wrote: > On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: >> On 10.07.2025 03:35, dm...@proton.me wrote: >>> @@ -877,6 +873,16 @@ struct domain *domain_create(domid_t domid, >>> >>> /* All error paths can depend on the above setup. */ >>> >>> +

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-10 Thread dmkhn
On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: > On 10.07.2025 03:35, dm...@proton.me wrote: > > @@ -877,6 +873,16 @@ struct domain *domain_create(domid_t domid, > > > > /* All error paths can depend on the above setup. */ > > > > +BUILD_BUG_ON(DOMAIN_CONSOLE_BUF_SIZE <= 0);

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-10 Thread Jan Beulich
On 10.07.2025 03:35, dm...@proton.me wrote: > @@ -877,6 +873,16 @@ struct domain *domain_create(domid_t domid, > > /* All error paths can depend on the above setup. */ > > +BUILD_BUG_ON(DOMAIN_CONSOLE_BUF_SIZE <= 0); While the "equals 0" case can in principle happen, the "less than" p

[PATCH v6] xen/console: introduce domain_console struct

2025-07-09 Thread dmkhn
From: Denis Mukhin Introduce domain_console for grouping data structures used for integrating domain's diagnostic console with Xen's console driver. Group all pbuf-related data structures under domain_console. Rename the moved fields to plain .buf, .idx and .lock names, since all uses of the fi