[PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-15 Thread Bertrand Marquis
From: Rahul Singh The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space. A MMIO trap handler for the PCI E

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-15 Thread Julien Grall
Hi Bertrand, On 15/10/2021 17:51, Bertrand Marquis wrote: diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 3aa8c3175f..35e0190796 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-15 Thread Bertrand Marquis
Hi Julien, > On 15 Oct 2021, at 18:25, Julien Grall wrote: > > Hi Bertrand, > > On 15/10/2021 17:51, Bertrand Marquis wrote: >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c >> index 3aa8c3175f..35e0190796 100644 >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/d

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-15 Thread Julien Grall
On 15/10/2021 18:33, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 15 Oct 2021, at 18:25, Julien Grall wrote: Hi Bertrand, On 15/10/2021 17:51, Bertrand Marquis wrote: diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 3aa8c3175f..35e0190796 100644

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-15 Thread Stefano Stabellini
On Fri, 15 Oct 2021, Julien Grall wrote: > On 15/10/2021 18:33, Bertrand Marquis wrote: > > > On 15 Oct 2021, at 18:25, Julien Grall wrote: > > > > > > Hi Bertrand, > > > > > > On 15/10/2021 17:51, Bertrand Marquis wrote: > > > > diff --git a/xen/drivers/passthrough/pci.c > > > > b/xen/drivers/p

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-16 Thread Roger Pau Monné
On Fri, Oct 15, 2021 at 12:47:17PM -0700, Stefano Stabellini wrote: > On Fri, 15 Oct 2021, Julien Grall wrote: > > On 15/10/2021 18:33, Bertrand Marquis wrote: > > > > On 15 Oct 2021, at 18:25, Julien Grall wrote: > > > > > > > > Hi Bertrand, > > > > > > > > On 15/10/2021 17:51, Bertrand Marquis

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 16.10.2021 12:28, Roger Pau Monné wrote: > On Fri, Oct 15, 2021 at 12:47:17PM -0700, Stefano Stabellini wrote: >> On Fri, 15 Oct 2021, Julien Grall wrote: >>> On 15/10/2021 18:33, Bertrand Marquis wrote: > On 15 Oct 2021, at 18:25, Julien Grall wrote: > > Hi Bertrand, > > On

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 15.10.2021 18:51, Bertrand Marquis wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c > @@ -0,0 +1,77 @@ > +/* > + * xen/arch/arm/vpci.c > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > +

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 15.10.2021 20:38, Julien Grall wrote: > > > On 15/10/2021 18:33, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >> >>> On 15 Oct 2021, at 18:25, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 15/10/2021 17:51, Bertrand Marquis wrote: diff --git a/xen/drivers/passthrough/

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Roger Pau Monné
On Mon, Oct 18, 2021 at 09:47:06AM +0200, Jan Beulich wrote: > On 15.10.2021 18:51, Bertrand Marquis wrote: > > --- /dev/null > > +++ b/xen/arch/arm/vpci.c > > @@ -0,0 +1,77 @@ > > +/* > > + * xen/arch/arm/vpci.c > > + * > > + * This program is free software; you can redistribute it and/or modify >

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Bertrand Marquis
Hi Jan, > On 18 Oct 2021, at 08:51, Jan Beulich wrote: > > On 15.10.2021 20:38, Julien Grall wrote: >> >> >> On 15/10/2021 18:33, Bertrand Marquis wrote: >>> Hi Julien, >> >> Hi Bertrand, >> >>> On 15 Oct 2021, at 18:25, Julien Grall wrote: Hi Bertrand, On 15/10/

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 18.10.2021 10:03, Roger Pau Monné wrote: > On Mon, Oct 18, 2021 at 09:47:06AM +0200, Jan Beulich wrote: >> On 15.10.2021 18:51, Bertrand Marquis wrote: >>> --- /dev/null >>> +++ b/xen/arch/arm/vpci.c >>> @@ -0,0 +1,77 @@ >>> +/* >>> + * xen/arch/arm/vpci.c >>> + * >>> + * This program is free so

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Oleksandr Andrushchenko
Hi, Jan! On 18.10.21 10:47, Jan Beulich wrote: > On 15.10.2021 18:51, Bertrand Marquis wrote: >> --- /dev/null >> +++ b/xen/arch/arm/vpci.c >> @@ -0,0 +1,77 @@ >> +/* >> + * xen/arch/arm/vpci.c >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the t

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Bertrand Marquis
Hi Jan, > On 18 Oct 2021, at 08:47, Jan Beulich wrote: > > On 15.10.2021 18:51, Bertrand Marquis wrote: >> --- /dev/null >> +++ b/xen/arch/arm/vpci.c >> @@ -0,0 +1,77 @@ >> +/* >> + * xen/arch/arm/vpci.c >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 18.10.2021 12:11, Bertrand Marquis wrote: >> On 18 Oct 2021, at 08:47, Jan Beulich wrote: >> On 15.10.2021 18:51, Bertrand Marquis wrote: >>> --- /dev/null >>> +++ b/xen/arch/arm/vpci.c >>> @@ -0,0 +1,77 @@ >>> +/* >>> + * xen/arch/arm/vpci.c >>> + * >>> + * This program is free software; you c

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Oleksandr Andrushchenko
On 18.10.21 13:29, Jan Beulich wrote: > On 18.10.2021 12:11, Bertrand Marquis wrote: >>> On 18 Oct 2021, at 08:47, Jan Beulich wrote: >>> On 15.10.2021 18:51, Bertrand Marquis wrote: --- /dev/null +++ b/xen/arch/arm/vpci.c @@ -0,0 +1,77 @@ +/* + * xen/arch/arm/vpci.c >>>

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 18.10.2021 16:07, Oleksandr Andrushchenko wrote: > On 18.10.21 13:29, Jan Beulich wrote: >> On 18.10.2021 12:11, Bertrand Marquis wrote: On 18 Oct 2021, at 08:47, Jan Beulich wrote: On 15.10.2021 18:51, Bertrand Marquis wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c >

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Oleksandr Andrushchenko
On 18.10.21 17:19, Jan Beulich wrote: > On 18.10.2021 16:07, Oleksandr Andrushchenko wrote: >> On 18.10.21 13:29, Jan Beulich wrote: >>> On 18.10.2021 12:11, Bertrand Marquis wrote: > On 18 Oct 2021, at 08:47, Jan Beulich wrote: > On 15.10.2021 18:51, Bertrand Marquis wrote: >> --- /

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM

2021-10-18 Thread Jan Beulich
On 18.10.2021 16:37, Oleksandr Andrushchenko wrote: > > > On 18.10.21 17:19, Jan Beulich wrote: >> On 18.10.2021 16:07, Oleksandr Andrushchenko wrote: >>> On 18.10.21 13:29, Jan Beulich wrote: On 18.10.2021 12:11, Bertrand Marquis wrote: >> On 18 Oct 2021, at 08:47, Jan Beulich wrote: >

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM [and 1 more messages]

2021-10-18 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM"): > AFAICT, the code is not reachable on Arm (?). Therefore, one could argue > we this can wait after the week-end as this is a latent bug. Yet, I am > not really comfortabl

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM [and 1 more messages]

2021-10-18 Thread Bertrand Marquis
Hi Ian, > On 18 Oct 2021, at 11:38, Ian Jackson wrote: > > Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 > virtual PCI support for ARM"): >> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue >> we this can wa

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM [and 1 more messages]

2021-10-18 Thread Jan Beulich
On 18.10.2021 12:38, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 > virtual PCI support for ARM"): >> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue >> we this can wait after the week-end as