Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

2022-12-20 Thread Xenia Ragiadakou
On 12/20/22 19:04, Jan Beulich wrote: On 19.12.2022 07:34, Xenia Ragiadakou wrote: Move its definition to the AMD-Vi driver and use CONFIG_AMD_IOMMU to guard its usage in common code. Take the opportunity to replace bool_t with bool and 1 with true. Please further take the opportunity and u

Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

2022-12-20 Thread Xenia Ragiadakou
On 12/20/22 12:31, Andrew Cooper wrote: On 19/12/2022 6:34 am, Xenia Ragiadakou wrote: diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 5e2a720d29..1a02fdc453 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -58,7 +58,6 @

Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

2022-12-20 Thread Jan Beulich
On 19.12.2022 07:34, Xenia Ragiadakou wrote: > Move its definition to the AMD-Vi driver and use CONFIG_AMD_IOMMU > to guard its usage in common code. > > Take the opportunity to replace bool_t with bool and 1 with true. Please further take the opportunity and use ... > --- a/xen/drivers/passthro

Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

2022-12-20 Thread Andrew Cooper
On 19/12/2022 6:34 am, Xenia Ragiadakou wrote: > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c > index 5e2a720d29..1a02fdc453 100644 > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -58,7 +58,6 @@ bool __read_mostly iommu_hap_pt_s

[RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

2022-12-18 Thread Xenia Ragiadakou
Move its definition to the AMD-Vi driver and use CONFIG_AMD_IOMMU to guard its usage in common code. Take the opportunity to replace bool_t with bool and 1 with true. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/drivers/passthrough/amd/iommu_init.c | 2 ++ xen/drivers